From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACA31EB3D for ; Fri, 27 Oct 2023 13:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pW6FLLzr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 338ADC433C7; Fri, 27 Oct 2023 13:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698413617; bh=mkOAnvc/y5wxjD9fXidKsxRBk6fewzPGPXWV4xJ0YoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW6FLLzrRuFXBKlkMAVKVRP6B3RxZ8In9jAfCOPWFr16tWZbGQDWD5Epqb9vU1f4Y J87uvzRTKxM3lkIyNhQGUO2THqxsHkPcssnPkp3e7o3AyJVJ2TbHWefrOWK/b3F0qv DbKWsp4QxJR+UXPysGYq7sFiA9c2BTLbOolNUiiJ2cFPUL4CCHbhwZ6v8zBkUP++qn rVSkwhC9QKh3S+LX0qhdWwu8KfBOIj6jEEJ+AZb1kmEfyNg2crak8yMkvM4IfQlfir AsaJRzNVJbJJ+7ZJdGXZkiVCC8AMlkhlZv5/M9ZJI1seHR9UPAH3Yf3F5Hag9Q0Uy1 SX+2gKi4C++EQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8BCBE4035D; Fri, 27 Oct 2023 10:33:30 -0300 (-03) Date: Fri, 27 Oct 2023 10:33:30 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Yang Jihong , Adrian Hunter , Ian Rogers , Jiri Olsa , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org Subject: [PATCH 1/1] perf python: Fix binding linkage due to rename and move of evsel__increase_rlimit() Message-ID: References: <20231023033144.1011896-1-yangjihong1@huawei.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: The changes in ("perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile") ended up breaking the python binding that now references the rlimit__increase_nofile function, add the util/rlimit.o to the tools/perf/util/python-ext-sources to cure that. This was detected by the 'perf test python' regression test: $ perf test python 14: 'import perf' in python : FAILED! $ perf test -v python Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc 14: 'import perf' in python : --- start --- test child forked, pid 2912462 python usage test: "echo "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" | '/usr/bin/python3' " Traceback (most recent call last): File "", line 1, in ImportError: /tmp/build/perf-tools-next/python/perf.cpython-311-x86_64-linux-gnu.so: undefined symbol: rlimit__increase_nofile test child finished with -1 ---- end ---- 'import perf' in python: FAILED! $ Fixes: e093a222d7cba1eb ("perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile") Acked-by: Namhyung Kim Acked-by: Yang Jihong Cc: Adrian Hunter Cc: Ian Rogers Cc: Jiri Olsa Link: https://lore.kernel.org/lkml/ZTrCS5Z3PZAmfPdV@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/python-ext-sources | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources index 26e1c8d973ea0b95..593b660ec75e24e1 100644 --- a/tools/perf/util/python-ext-sources +++ b/tools/perf/util/python-ext-sources @@ -40,6 +40,7 @@ util/rwsem.c util/hashmap.c util/perf_regs.c util/fncache.c +util/rlimit.c util/perf-regs-arch/perf_regs_aarch64.c util/perf-regs-arch/perf_regs_arm.c util/perf-regs-arch/perf_regs_csky.c -- 2.41.0