* [PATCH 3/3] perf/x86/amd:Convert snprintf() to sysfs_emit()
@ 2023-11-03 23:57 Jules Irenge
0 siblings, 0 replies; only message in thread
From: Jules Irenge @ 2023-11-03 23:57 UTC (permalink / raw)
To: irogers
Cc: adrian.hunter, tglx, bp, dave.hansen, x86, hpa, linux-perf-users,
linux-kernel
Coccinelle reports a warning
WARNING: use scnprintf or sprintf
Following the advice on kernel documentation
https://www.kernel.org/doc/html/latest/filesystems/sysfs.html
For show(device *...) functions, only use sysfs_emit() or sysfs_emit_at()
especially when formatting the value to be returned to user space.
Convert snprintf() to sysfs_emit()
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/events/amd/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index e24976593a29..f2fef75d464c 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -1279,7 +1279,7 @@ static ssize_t branches_show(struct device *cdev,
struct device_attribute *attr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%d\n", x86_pmu.lbr_nr);
+ return sysfs_emit(buf, "%d\n", x86_pmu.lbr_nr);
}
static DEVICE_ATTR_RO(branches);
--
2.41.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-03 23:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-03 23:57 [PATCH 3/3] perf/x86/amd:Convert snprintf() to sysfs_emit() Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).