From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB815F1CB for ; Tue, 5 Dec 2023 15:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dRgmc4Xm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FA5EC433C7; Tue, 5 Dec 2023 15:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701791689; bh=o4aVIuxjrPEXq7MUNeoMQrjgq/QwX2+q3NVUago8P7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dRgmc4XmccVhcTfMfbDmDehBpfSndSKD/y93zlELkc5mWZiKKovHFS3gWclmxXVIy hZEI2z6LQK8m+cCfbjUlGDqAa/y9XMPoyKOszXOZQbz12D+ubBvBzAYDhwZCdqk8ir jZmw7iPfYEayqp7ormZgukPAeck0Q0Mx8qnDPfDOu/B31JUC2HYxSIKujZkzwszZGu cwD62+lDx4Ccb4CQNig2XqPubnDuBMrTVt/Wg2RsUPW4ZohUJWMI+bvpGeTV6k0nyy LusVQ4WkTjrlV8H+o1KEPGx+ADPDOut+I09KhEOyeEokMw8RRFYciqvOvc9dv4ipn0 TCg8Z1eAYbQUw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3CDEB40094; Tue, 5 Dec 2023 12:54:47 -0300 (-03) Date: Tue, 5 Dec 2023 12:54:47 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Nick Terrell , Kan Liang , Andi Kleen , Kajol Jain , Athira Rajeev , Huacai Chen , Masami Hiramatsu , Vincent Whitchurch , "Steinar H. Gunderson" , Liam Howlett , Miguel Ojeda , Colin Ian King , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , Ming Wang , James Clark , K Prateek Nayak , Sean Christopherson , Leo Yan , Ravi Bangoria , German Gomez , Changbin Du , Paolo Bonzini , Li Dong , Sandipan Das , liuwenyu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Guilherme Amadio Subject: Re: [PATCH v5 08/50] perf record: Be lazier in allocating lost samples buffer Message-ID: References: <20231127220902.1315692-1-irogers@google.com> <20231127220902.1315692-9-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Sat, Dec 02, 2023 at 03:56:48PM -0800, Namhyung Kim escreveu: > On Thu, Nov 30, 2023 at 10:29 AM Ian Rogers wrote: > > On Wed, Nov 29, 2023 at 6:09 PM Namhyung Kim wrote: > > > To minimize the allocation size, this can be > > > sizeof(*lost) + session->machines.host.id_hdr_size > > > instead of PERF_SAMPLE_MAX_SIZE. > > > > Sounds good, should probably be a follow up. The current size is > > PERF_SAMPLE_MAX_SIZE. > > Yep, I'm ok with having it as a follow-up. > > Acked-by: Namhyung Kim Thanks, applied to perf-tools-next. - Arnaldo