* [PATCH v1] perf vendor events: Add skx, clx, icx and spr upi bandwidth metric
@ 2023-11-09 23:27 Ian Rogers
2023-11-27 18:17 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2023-11-09 23:27 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, Kan Liang, linux-perf-users, linux-kernel,
Perry Taylor, Caleb Biggers
Cc: Ian Rogers
Add upi_data_receive_bw metric for skylakex, cascadelakex, icelakex
and sapphirerapids. The metric was added to perfmon metrics in:
https://github.com/intel/perfmon/pull/119
Signed-off-by: Ian Rogers <irogers@google.com>
---
.../perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 6 ++++++
tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json | 6 ++++++
.../pmu-events/arch/x86/sapphirerapids/spr-metrics.json | 6 ++++++
tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 6 ++++++
4 files changed, 24 insertions(+)
diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
index 84c132af3dfa..8bc6c0707856 100644
--- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
@@ -1862,6 +1862,12 @@
"MetricName": "uncore_frequency",
"ScaleUnit": "1GHz"
},
+ {
+ "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
+ "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
+ "MetricName": "upi_data_receive_bw",
+ "ScaleUnit": "1MB/s"
+ },
{
"BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
"MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
diff --git a/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json b/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
index e98602c66707..71d78a7841ea 100644
--- a/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
@@ -1846,6 +1846,12 @@
"MetricName": "uncore_frequency",
"ScaleUnit": "1GHz"
},
+ {
+ "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
+ "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
+ "MetricName": "upi_data_receive_bw",
+ "ScaleUnit": "1MB/s"
+ },
{
"BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
"MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
diff --git a/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json b/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
index 06c6d67cb76b..e31a4aac9f20 100644
--- a/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
@@ -1964,6 +1964,12 @@
"MetricName": "uncore_frequency",
"ScaleUnit": "1GHz"
},
+ {
+ "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
+ "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
+ "MetricName": "upi_data_receive_bw",
+ "ScaleUnit": "1MB/s"
+ },
{
"BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
"MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
index 4a8f8eeb7525..ec3aa5ef00a3 100644
--- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
+++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
@@ -1806,6 +1806,12 @@
"MetricName": "uncore_frequency",
"ScaleUnit": "1GHz"
},
+ {
+ "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
+ "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
+ "MetricName": "upi_data_receive_bw",
+ "ScaleUnit": "1MB/s"
+ },
{
"BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
"MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
--
2.43.0.rc0.421.g78406f8d94-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf vendor events: Add skx, clx, icx and spr upi bandwidth metric
2023-11-09 23:27 [PATCH v1] perf vendor events: Add skx, clx, icx and spr upi bandwidth metric Ian Rogers
@ 2023-11-27 18:17 ` Ian Rogers
2023-11-27 18:44 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2023-11-27 18:17 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, Kan Liang, linux-perf-users, linux-kernel,
Perry Taylor, Caleb Biggers
On Thu, Nov 9, 2023 at 3:28 PM Ian Rogers <irogers@google.com> wrote:
>
> Add upi_data_receive_bw metric for skylakex, cascadelakex, icelakex
> and sapphirerapids. The metric was added to perfmon metrics in:
> https://github.com/intel/perfmon/pull/119
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Ping.
Thanks,
Ian
> ---
> .../perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 6 ++++++
> tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json | 6 ++++++
> .../pmu-events/arch/x86/sapphirerapids/spr-metrics.json | 6 ++++++
> tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json | 6 ++++++
> 4 files changed, 24 insertions(+)
>
> diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> index 84c132af3dfa..8bc6c0707856 100644
> --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
> @@ -1862,6 +1862,12 @@
> "MetricName": "uncore_frequency",
> "ScaleUnit": "1GHz"
> },
> + {
> + "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
> + "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> + "MetricName": "upi_data_receive_bw",
> + "ScaleUnit": "1MB/s"
> + },
> {
> "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
> "MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> diff --git a/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json b/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> index e98602c66707..71d78a7841ea 100644
> --- a/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json
> @@ -1846,6 +1846,12 @@
> "MetricName": "uncore_frequency",
> "ScaleUnit": "1GHz"
> },
> + {
> + "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
> + "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> + "MetricName": "upi_data_receive_bw",
> + "ScaleUnit": "1MB/s"
> + },
> {
> "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
> "MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> diff --git a/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json b/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
> index 06c6d67cb76b..e31a4aac9f20 100644
> --- a/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/sapphirerapids/spr-metrics.json
> @@ -1964,6 +1964,12 @@
> "MetricName": "uncore_frequency",
> "ScaleUnit": "1GHz"
> },
> + {
> + "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
> + "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> + "MetricName": "upi_data_receive_bw",
> + "ScaleUnit": "1MB/s"
> + },
> {
> "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
> "MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> diff --git a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> index 4a8f8eeb7525..ec3aa5ef00a3 100644
> --- a/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> +++ b/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
> @@ -1806,6 +1806,12 @@
> "MetricName": "uncore_frequency",
> "ScaleUnit": "1GHz"
> },
> + {
> + "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data receive bandwidth (MB/sec)",
> + "MetricExpr": "UNC_UPI_RxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> + "MetricName": "upi_data_receive_bw",
> + "ScaleUnit": "1MB/s"
> + },
> {
> "BriefDescription": "Intel(R) Ultra Path Interconnect (UPI) data transmit bandwidth (MB/sec)",
> "MetricExpr": "UNC_UPI_TxL_FLITS.ALL_DATA * 7.111111111111111 / 1e6 / duration_time",
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf vendor events: Add skx, clx, icx and spr upi bandwidth metric
2023-11-27 18:17 ` Ian Rogers
@ 2023-11-27 18:44 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-11-27 18:44 UTC (permalink / raw)
To: Ian Rogers
Cc: Kan Liang, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Adrian Hunter,
linux-perf-users, linux-kernel, Perry Taylor, Caleb Biggers
Em Mon, Nov 27, 2023 at 10:17:48AM -0800, Ian Rogers escreveu:
> On Thu, Nov 9, 2023 at 3:28 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Add upi_data_receive_bw metric for skylakex, cascadelakex, icelakex
> > and sapphirerapids. The metric was added to perfmon metrics in:
> > https://github.com/intel/perfmon/pull/119
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Ping.
No Acked-by from Intel people, please consider providing it in the
future.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-27 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-09 23:27 [PATCH v1] perf vendor events: Add skx, clx, icx and spr upi bandwidth metric Ian Rogers
2023-11-27 18:17 ` Ian Rogers
2023-11-27 18:44 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).