From: Oliver Upton <oliver.upton@linux.dev>
To: Mark Brown <broonie@kernel.org>
Cc: linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 2/2] perf build: Ensure sysreg-defs Makefile respects output dir
Date: Sat, 2 Dec 2023 13:34:20 -0800 [thread overview]
Message-ID: <ZWui3KxloT5tcIsJ@thinky-boi> (raw)
In-Reply-To: <c701bf6b-0ff0-44a0-9d1d-84e8515d077c@sirena.org.uk>
Hey Mark,
Thanks for the bug report. Apologies for the latency on my end, I've had
a mountain of non-upstream stuff to wade through.
On Wed, Nov 29, 2023 at 04:27:01PM +0000, Mark Brown wrote:
> On Tue, Nov 21, 2023 at 07:29:56PM +0000, Oliver Upton wrote:
>
> > Currently the sysreg-defs are written out to the source tree
> > unconditionally, ignoring the specified output directory. Correct the
> > build rule to emit the header to the output directory. Opportunistically
> > reorganize the rules to avoid interleaving with the set of beauty make
> > rules.
>
> This breaks some build configurations:
>
> Running:
>
> make --silent --keep-going --jobs=56 O=/home/broonie/.cache/tuxmake/builds/16/build ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- LLVM=1 defconfig
> make --silent --keep-going --jobs=56 O=/home/broonie/.cache/tuxmake/builds/16/bu
> ild INSTALL_PATH=/home/broonie/.cache/tuxmake/builds/16/build/kselftest_install
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- LLVM=1 kselftest-install
>
> gives:
>
> make[4]: Leaving directory '/home/broonie/git/bisect/tools/testing/selftests/kex
> ec'
> make[4]: Entering directory '/home/broonie/git/bisect/tools/testing/selftests/kvm'
> Makefile:270: warning: overriding recipe for target '/home/broonie/.cache/tuxmake/builds/16/build/kselftest/kvm/get-reg-list'
> Makefile:265: warning: ignoring old recipe for target '/home/broonie/.cache/tuxmake/builds/16/build/kselftest/kvm/get-reg-list'
> make -C ../../../../tools/arch/arm64/tools/ O=../../../../tools
> make[5]: Entering directory '/home/broonie/git/bisect/tools/arch/arm64/tools'
> /home/broonie/git/bisect/tools/scripts/Makefile.include:4: *** O=../../../../tools does not exist. Stop.
Looks like its because $(PWD) is tools/testing/selftests/ when building
from the top level makefile. I'll get a fix out in the next couple days
after I find my Make dunce cap :)
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-12-02 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 19:29 [PATCH 0/2] perf build: Fixes for arm64 sysreg-defs build rules Oliver Upton
2023-11-21 19:29 ` [PATCH 1/2] tools perf: Add arm64 sysreg files to MANIFEST Oliver Upton
2023-11-21 19:29 ` [PATCH 2/2] perf build: Ensure sysreg-defs Makefile respects output dir Oliver Upton
2023-11-29 16:27 ` Mark Brown
2023-12-02 21:34 ` Oliver Upton [this message]
2023-12-06 13:45 ` Mark Brown
2023-12-11 13:19 ` Mark Brown
2023-12-11 22:47 ` Namhyung Kim
2023-12-12 7:07 ` Oliver Upton
2023-11-22 20:36 ` [PATCH 0/2] perf build: Fixes for arm64 sysreg-defs build rules Ian Rogers
2023-11-22 21:16 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWui3KxloT5tcIsJ@thinky-boi \
--to=oliver.upton@linux.dev \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=broonie@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).