From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF0F37156 for ; Wed, 6 Dec 2023 13:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oaBtu7yk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3CB4C433C7; Wed, 6 Dec 2023 13:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701869170; bh=kY88AoLa3ot5oNZ2xunTh93/qoZpoRK13BhBUv2JbLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oaBtu7ykS3bebpcM/l82Q0Ed1Cz+UbZbBJop+Z4dY/WMjGyu0MwOHg3k7VkIwXtXW 3f3Y0rNE3DApL2F+IMTJslYub2smDvJoT2xq5SC5B6V7xSNPV6TADRmyaAE0ilsAkj GwqPNKytF54L6R4f6e0Z3PbsG/9WwdVDzheGvFEWenroxDalPm2CjA4SihZEKpW5TI f8+eduyfRYOmB8CwXoCUK3zgtlusG/UNyokxhkmBHiMY2bmJN7T3xACidHBZ4rbbc0 stK0nhgErVd6pqbYyhRlru/2W8UX+0Rb4mCzbQfW01Ts2zE7YXK4lzIlxpSZuKgz0x OlpqmpXByvPsA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 99789403EF; Wed, 6 Dec 2023 10:26:07 -0300 (-03) Date: Wed, 6 Dec 2023 10:26:07 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, atrajeev@linux.vnet.ibm.com Subject: Re: [PATCH v1] perf test: Add basic perf diff test Message-ID: References: <20231120190408.281826-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Tue, Dec 05, 2023 at 08:52:04AM -0800, Ian Rogers escreveu: > On Mon, Dec 4, 2023 at 9:44 PM Adrian Hunter wrote: > > > > On 4/12/23 18:00, Ian Rogers wrote: > > > On Mon, Nov 20, 2023 at 11:04 AM Ian Rogers wrote: > > >> > > >> There are some old bug reports on perf diff crashing: > > >> https://rhaas.blogspot.com/2012/06/perf-good-bad-ugly.html > > >> > > >> Happening across them I was prompted to add two very basic tests that > > >> will give some perf diff coverage. > > >> > > >> Signed-off-by: Ian Rogers > > > > > > Ping. > > > > > > Thanks, > > > Ian > > > > > >> --- > > >> tools/perf/tests/shell/diff.sh | 101 +++++++++++++++++++++++++++++++++ > > >> 1 file changed, 101 insertions(+) > > >> create mode 100755 tools/perf/tests/shell/diff.sh > > >> > > >> diff --git a/tools/perf/tests/shell/diff.sh b/tools/perf/tests/shell/diff.sh > > >> new file mode 100755 > > >> index 000000000000..213185763688 > > >> --- /dev/null > > >> +++ b/tools/perf/tests/shell/diff.sh > > >> @@ -0,0 +1,101 @@ > > >> +#!/bin/sh > > >> +# perf diff tests > > >> +# SPDX-License-Identifier: GPL-2.0 > > >> + > > >> +set -e > > >> + > > >> +err=0 > > >> +perfdata1=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > > >> +perfdata2=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > > >> +perfdata3=$(mktemp /tmp/__perf_test.perf.data.XXXXX) > > >> +testprog="perf test -w thloop" > > >> +testsym="test_loop" > > > > Could it benefit from skip_test_missing_symbol > > Good idea, sent: > https://lore.kernel.org/lkml/20231205164924.835682-1-irogers@google.com/ Applied, and added this: Suggested-by: Adrian Hunter Thanks, - Arnaldo