From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E7F5364C3 for ; Wed, 6 Dec 2023 12:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GOytNp2p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC65EC433C9; Wed, 6 Dec 2023 12:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701865731; bh=VVk9kQHEnMbycIorFX5k/DX3qnjW1iukn5lB2/0YVs4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GOytNp2pZ2rZJLw6dK5rXdIrQhEzaHpr+XF9wzgaQqHr5c5BSn4qIx9AGigGG/SAW rhkdsHbG0VuLLxAAXluNxhBIXaDL9K3bpW6WuU0HeZCyc1eqt6RwLazz3DeuQxJbUp l8B3WEt2VHB85qPA74XPWLu282GrRJG9e3i6reciz56ID0Y2EJ8XHpE2qbhI8Uq57x Vft0/dU5Qdwg1puSiNKnKqtUGAt4wmKkceR9LZyG09EHchRG3GAD25+Elcn7tuqX5X uVWq4lxgM3SQ5riluNHzOb6OuKSqcYuHkIlgBEg31CoOSvYrtxBMajkzlLLWbf3lum 2OSeloi0QGNQg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 2C7764041A; Wed, 6 Dec 2023 09:28:49 -0300 (-03) Date: Wed, 6 Dec 2023 09:28:49 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , Athira Rajeev , jolsa@kernel.org, adrian.hunter@intel.com, namhyung@kernel.org, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com Subject: Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf Message-ID: References: <20231123160232.94253-1-atrajeev@linux.vnet.ibm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Tue, Dec 05, 2023 at 02:09:01PM -0800, Ian Rogers escreveu: > On Tue, Dec 5, 2023 at 1:50 PM Arnaldo Carvalho de Melo wrote: > > > > Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu: > > > On 23/11/2023 16:02, Athira Rajeev wrote: > > > > --- a/tools/perf/Makefile.perf > > > > @@ -1134,6 +1152,7 @@ bpf-skel-clean: > > > > $(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS) > > > > > > > > clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $(LIBPERF)-clean fixdep-clean python-clean bpf-skel-clean tests-coresight-targets-clean > > > > + $(Q)$(MAKE) -f $(srctree)/tools/perf/tests/Makefile.tests clean > > > > $(call QUIET_CLEAN, core-objs) $(RM) $(LIBPERF_A) $(OUTPUT)perf-archive $(OUTPUT)perf-iostat $(LANG_BINDINGS) > > > > $(Q)find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete > > > > $(Q)$(RM) $(OUTPUT).config-detected > > > > While merging perf-tools-next with torvalds/master I noticed that maybe > > we better have the above added line as: > > > > + $(call QUIET_CLEAN, tests) $(Q)$(MAKE) -f $(srctree)/tools/perf/tests/Makefile.tests clean > > > > No? > > > > Anyway I'm merging as-is, but it just hit my eye while merging, > > > > - Arnaldo > > Makefile.tests was removed in these recent patches adding support for > the OUTPUT directory: > https://lore.kernel.org/lkml/9C33887F-8A88-4973-8593-7936E36AFCE1@linux.vnet.ibm.com/ Right, I made a mistake and was doing the merge on a different branch, now that I tried it on my latest perf-tools-next local branch all is well and the other merge conflict gets auto-resolved (arm64-sysreg-defs-clean stuff in tools/perf/Makefile.perf "clean" target). Thanks for checking, - Arnaldo