* [PATCH v1] perf tests: Make DSO tests a suite rather than individual
@ 2023-11-28 19:46 Ian Rogers
2023-12-18 20:31 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2023-11-28 19:46 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, James Clark, Kan Liang, Yang Jihong,
linux-perf-users, linux-kernel
Make the DSO data tests a suite rather than individual so their output
is grouped.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/builtin-test.c | 2 --
tools/perf/tests/dso-data.c | 15 ++++++++++++---
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 113e92119e1d..9c09e4681c3a 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -62,8 +62,6 @@ static struct test_suite *generic_tests[] = {
&suite__pmu,
&suite__pmu_events,
&suite__dso_data,
- &suite__dso_data_cache,
- &suite__dso_data_reopen,
&suite__perf_evsel__roundtrip_name_test,
#ifdef HAVE_LIBTRACEEVENT
&suite__perf_evsel__tp_sched_test,
diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index deaefcdd8f09..5286ae8bd2d7 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -393,6 +393,15 @@ static int test__dso_data_reopen(struct test_suite *test __maybe_unused, int sub
return 0;
}
-DEFINE_SUITE("DSO data read", dso_data);
-DEFINE_SUITE("DSO data cache", dso_data_cache);
-DEFINE_SUITE("DSO data reopen", dso_data_reopen);
+
+static struct test_case tests__dso_data[] = {
+ TEST_CASE("read", dso_data),
+ TEST_CASE("cache", dso_data_cache),
+ TEST_CASE("reopen", dso_data_reopen),
+ { .name = NULL, }
+};
+
+struct test_suite suite__dso_data = {
+ .desc = "DSO data tests",
+ .test_cases = tests__dso_data,
+};
--
2.43.0.rc1.413.gea7ed67945-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf tests: Make DSO tests a suite rather than individual
2023-11-28 19:46 [PATCH v1] perf tests: Make DSO tests a suite rather than individual Ian Rogers
@ 2023-12-18 20:31 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-12-18 20:31 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Adrian Hunter, James Clark, Kan Liang,
Yang Jihong, linux-perf-users, linux-kernel
Em Tue, Nov 28, 2023 at 11:46:24AM -0800, Ian Rogers escreveu:
> Make the DSO data tests a suite rather than individual so their output
> is grouped.
Thanks, applied to perf-tools-next.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/builtin-test.c | 2 --
> tools/perf/tests/dso-data.c | 15 ++++++++++++---
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 113e92119e1d..9c09e4681c3a 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -62,8 +62,6 @@ static struct test_suite *generic_tests[] = {
> &suite__pmu,
> &suite__pmu_events,
> &suite__dso_data,
> - &suite__dso_data_cache,
> - &suite__dso_data_reopen,
> &suite__perf_evsel__roundtrip_name_test,
> #ifdef HAVE_LIBTRACEEVENT
> &suite__perf_evsel__tp_sched_test,
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index deaefcdd8f09..5286ae8bd2d7 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -393,6 +393,15 @@ static int test__dso_data_reopen(struct test_suite *test __maybe_unused, int sub
> return 0;
> }
>
> -DEFINE_SUITE("DSO data read", dso_data);
> -DEFINE_SUITE("DSO data cache", dso_data_cache);
> -DEFINE_SUITE("DSO data reopen", dso_data_reopen);
> +
> +static struct test_case tests__dso_data[] = {
> + TEST_CASE("read", dso_data),
> + TEST_CASE("cache", dso_data_cache),
> + TEST_CASE("reopen", dso_data_reopen),
> + { .name = NULL, }
> +};
> +
> +struct test_suite suite__dso_data = {
> + .desc = "DSO data tests",
> + .test_cases = tests__dso_data,
> +};
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-18 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 19:46 [PATCH v1] perf tests: Make DSO tests a suite rather than individual Ian Rogers
2023-12-18 20:31 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).