* [PATCH] perf test: Remove the temporary trace record file when the test fails
@ 2025-04-05 1:47 Howard Chu
2025-04-10 7:10 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Howard Chu @ 2025-04-05 1:47 UTC (permalink / raw)
To: acme
Cc: mingo, namhyung, mark.rutland, alexander.shishkin, jolsa, irogers,
adrian.hunter, peterz, kan.liang, linux-perf-users, linux-kernel,
Howard Chu
Even if there's no nanosleep in the trace record file, it doesn't mean
the file itself doesn't exist. Remove the temporary file since the test
frequently fails on my machine and leaves behind many uncleaned
temporary files.
Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
tools/perf/tests/shell/trace_record_replay.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/shell/trace_record_replay.sh b/tools/perf/tests/shell/trace_record_replay.sh
index 6b4ed863c1ef..555537dc6cfa 100755
--- a/tools/perf/tests/shell/trace_record_replay.sh
+++ b/tools/perf/tests/shell/trace_record_replay.sh
@@ -15,6 +15,7 @@ file=$(mktemp /tmp/temporary_file.XXXXX)
perf trace record -o ${file} sleep 1 || exit 1
if ! perf trace -i ${file} 2>&1 | grep nanosleep; then
echo "Failed: cannot find *nanosleep syscall"
+ rm -f ${file}
exit 1
fi
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf test: Remove the temporary trace record file when the test fails
2025-04-05 1:47 [PATCH] perf test: Remove the temporary trace record file when the test fails Howard Chu
@ 2025-04-10 7:10 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2025-04-10 7:10 UTC (permalink / raw)
To: Howard Chu
Cc: acme, mingo, mark.rutland, alexander.shishkin, jolsa, irogers,
adrian.hunter, peterz, kan.liang, linux-perf-users, linux-kernel
On Fri, Apr 04, 2025 at 06:47:57PM -0700, Howard Chu wrote:
> Even if there's no nanosleep in the trace record file, it doesn't mean
> the file itself doesn't exist. Remove the temporary file since the test
> frequently fails on my machine and leaves behind many uncleaned
> temporary files.
>
> Signed-off-by: Howard Chu <howardchu95@gmail.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/tests/shell/trace_record_replay.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/shell/trace_record_replay.sh b/tools/perf/tests/shell/trace_record_replay.sh
> index 6b4ed863c1ef..555537dc6cfa 100755
> --- a/tools/perf/tests/shell/trace_record_replay.sh
> +++ b/tools/perf/tests/shell/trace_record_replay.sh
> @@ -15,6 +15,7 @@ file=$(mktemp /tmp/temporary_file.XXXXX)
> perf trace record -o ${file} sleep 1 || exit 1
> if ! perf trace -i ${file} 2>&1 | grep nanosleep; then
> echo "Failed: cannot find *nanosleep syscall"
> + rm -f ${file}
> exit 1
> fi
>
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-10 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-05 1:47 [PATCH] perf test: Remove the temporary trace record file when the test fails Howard Chu
2025-04-10 7:10 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).