From: Andi Kleen <ak@linux.intel.com>
To: Changbin Du <changbin.du@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Thomas Richter <tmricht@linux.ibm.com>,
changbin.du@gmail.com, Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v4 3/5] perf: script: add field 'disasm' to display mnemonic instructions
Date: Mon, 22 Jan 2024 05:41:42 -0800 [thread overview]
Message-ID: <Za5wluB2NckwNF0S@tassilo> (raw)
In-Reply-To: <20240122104646.oqa7jnmd6ed2dzdw@M910t>
> > >>
> > > Updated as:
> > >
> > > When doing instruction trace decoding, insn, disasm and insnlen give the
> > > instruction bytes, disassembled instructions and the instruction length
> > > of the current instruction respectively.
> >
> > I wondered about mentioning that disasm needs perf to be compiled with
> > disassembler support, but with a permissive license it seems likely
> > that libcapstone support would generally be built into perf, so that
> > should be fine.
> >
> Yes, libcapstone has a permissive license. It's available on most Linux distros.
What I've seen in the past is that people who build perf from source
often miss installing all the build the dependencies because perf continues
without an error. Make sure that if that happens and someone uses the option
there is a clear message that points to the build process.
-Andi
next prev parent reply other threads:[~2024-01-22 13:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:48 [PATCH v4 0/5] perf: script: Intro capstone disasm engine to show instruction trace Changbin Du
2024-01-19 10:48 ` [PATCH v4 1/5] perf: build: introduce the libcapstone Changbin Du
2024-01-19 18:38 ` Adrian Hunter
2024-01-20 7:23 ` Changbin Du
2024-01-19 10:48 ` [PATCH v4 2/5] perf: util: use capstone disasm engine to show assembly instructions Changbin Du
2024-01-19 18:39 ` Adrian Hunter
2024-01-20 9:13 ` Changbin Du
2024-01-22 8:24 ` Adrian Hunter
2024-01-22 8:42 ` Changbin Du
2024-01-19 10:48 ` [PATCH v4 3/5] perf: script: add field 'disasm' to display mnemonic instructions Changbin Du
2024-01-19 18:39 ` Adrian Hunter
2024-01-20 7:40 ` Changbin Du
2024-01-22 9:59 ` Adrian Hunter
2024-01-22 10:46 ` Changbin Du
2024-01-22 13:41 ` Andi Kleen [this message]
2024-01-22 14:05 ` Changbin Du
2024-01-19 10:48 ` [PATCH v4 4/5] perf: script: add raw|disasm arguments to --insn-trace option Changbin Du
2024-01-19 18:39 ` Adrian Hunter
2024-01-20 7:30 ` Changbin Du
2024-01-19 10:48 ` [PATCH v4 5/5] perf: script: prefer capstone to XED Changbin Du
2024-01-19 18:40 ` Adrian Hunter
2024-01-20 7:26 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za5wluB2NckwNF0S@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@gmail.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).