linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Clark Williams <williams@redhat.com>,
	Kate Carcia <kcarcia@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	James Clark <james.clark@arm.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Sun Haiyong <sunhaiyong@loongson.cn>,
	Thomas Richter <tmricht@linux.ibm.com>,
	Yanteng Si <siyanteng@loongson.cn>,
	Yicong Yang <yangyicong@hisilicon.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL] perf tools fixes for v6.8
Date: Thu, 1 Feb 2024 18:50:28 -0300	[thread overview]
Message-ID: <ZbwSJAayut8nXSXw@kernel.org> (raw)
In-Reply-To: <ZbwMjWO-AD1eB1a_@kernel.org>

Em Thu, Feb 01, 2024 at 06:26:37PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 01, 2024 at 01:21:16PM -0800, Linus Torvalds escreveu:
> > On Thu, 1 Feb 2024 at 13:14, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > I should've known better and not send the noisy JSON changes at this
> > > point in time.
> > 
> > Arnaldo, it's not the JSON changes in the history.
> > 
> > It's the absolute garbage in the *tag* itself. It's crazy. Do this"
> > 
> >    git fetch   git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git
> > perf-tools-fixes-for-v6.8-1-2024-02-01
> > 
> >    git cat-file tag FETCH_HEAD
> > 
> > and see complete and utter garbage in the tag contents.
> > 
> > Note: that is not a change *made* by the tag. It's literally just
> > garbage content in the tag *message* itself.
> > 
> > You have something *seriously* wrong with your scripting or tag
> > creation workflow.
> 
> Ok, I'll check, as I said I switched machines, I must've screwed up
> something.

	I created that tag, then realized I made a mistake, did a "git
show that-tag > /tmp/foo" to save the cover letter, then when recreating
e signed tag used the contents of that temp file, but forgot to remove
the end that contained the previous HEAD, d0h.

	I fixed the tag and force pushed it now, I looked at:

https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git/tag/?h=perf-tools-fixes-for-v6.8-1-2024-02-01

	And it has what was intended, hopefully no craziness now...

	Double checking:

[acme@quaco linux]$ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git perf-tools-fixes-for-v6.8-1-2024-02-01
remote: Enumerating objects: 2084, done.
remote: Counting objects: 100% (1075/1075), done.
remote: Compressing objects: 100% (20/20), done.
remote: Total 2084 (delta 1055), reused 1071 (delta 1053), pack-reused 1009
Receiving objects: 100% (2084/2084), 1.18 MiB | 1.15 MiB/s, done.
Resolving deltas: 100% (1589/1589), completed with 551 local objects.
From git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools
 * tag                                 perf-tools-fixes-for-v6.8-1-2024-02-01 -> FETCH_HEAD
[acme@quaco linux]$ 
[acme@quaco linux]$ git cat-file tag FETCH_HEAD | tail
  - Also, without tooling effects: asm-generic/unaligned.h, mount.h, fcntl.h, kvm headers.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQR2GiIUctdOfX2qHhGyPKLppCJ+JwUCZbwOmQAKCRCyPKLppCJ+
J/TkAP92DD1ZKmc9WzlJ8vpbz+nXwvMIDTRSSBnvYPiDNSL6xAEAkX92qWUQ35RS
faz2v593RZ4VfthcAEl5P6FXEhHhfAc=
=pDc1
-----END PGP SIGNATURE-----
[acme@quaco linux]$ 

- Arnaldo

  reply	other threads:[~2024-02-01 21:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 20:22 [GIT PULL] perf tools fixes for v6.8 Arnaldo Carvalho de Melo
2024-02-01 20:57 ` Linus Torvalds
2024-02-01 21:14   ` Arnaldo Carvalho de Melo
2024-02-01 21:21     ` Linus Torvalds
2024-02-01 21:26       ` Arnaldo Carvalho de Melo
2024-02-01 21:50         ` Arnaldo Carvalho de Melo [this message]
2024-02-03 13:15 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbwSJAayut8nXSXw@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kcarcia@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=siyanteng@loongson.cn \
    --cc=sunhaiyong@loongson.cn \
    --cc=tglx@linutronix.de \
    --cc=tmricht@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=williams@redhat.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).