From: Andi Kleen <ak@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-perf-users@vger.kernel.org, changbin.du@huawei.com
Subject: Re: [PATCH 1/2] perf, capstone: Support 32bit code under 64bit OS
Date: Wed, 28 Feb 2024 15:30:36 -0800 [thread overview]
Message-ID: <Zd_CHC8NOW5Ig7SE@tassilo> (raw)
In-Reply-To: <7ca41f7f-28b2-4f3c-8c04-1dba110d3135@intel.com>
> > + bool is64bit = machine__is(machine, "x86_64");
> > + struct dso *dso;
> > +
> > + addr_location__init(&al);
> > + if (thread__find_map(thread, sample->cpumode, sample->ip, &al) &&
> > + (dso = map__dso(al.map)) != NULL &&
> > + (dso->data.status != DSO_DATA_STATUS_ERROR)) {
> > + map__load(al.map);
> > + is64bit = dso->is_64_bit;
> > + }
> > + addr_location__exit(&al);
>
> Maybe 'al' could be passed down through perf_sample__fprintf_insn()
>
These are different addresses -- one is for the IP and the other is for
the immediate. It seems cleaner to support separate ones.
-Andi
next prev parent reply other threads:[~2024-02-28 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 23:48 [PATCH 1/2] perf, capstone: Support 32bit code under 64bit OS Andi Kleen
2024-02-27 23:48 ` [PATCH 2/2] perf, capstone: Support capstone for -F +brstackinsn Andi Kleen
2024-02-28 11:05 ` Changbin Du
2024-02-28 23:26 ` Andi Kleen
2024-02-28 11:00 ` [PATCH 1/2] perf, capstone: Support 32bit code under 64bit OS Changbin Du
2024-02-28 23:29 ` Andi Kleen
2024-02-28 11:42 ` Adrian Hunter
2024-02-28 23:30 ` Andi Kleen [this message]
2024-02-29 7:02 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd_CHC8NOW5Ig7SE@tassilo \
--to=ak@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=changbin.du@huawei.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).