From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ben Gainey <Ben.Gainey@arm.com>
Cc: "namhyung@kernel.org" <namhyung@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Clark <James.Clark@arm.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"irogers@google.com" <irogers@google.com>
Subject: Re: [PATCH v3 4/4] tools/perf: Allow inherit + inherit_stat + PERF_SAMPLE_READ when opening events
Date: Fri, 22 Mar 2024 11:31:27 -0300 [thread overview]
Message-ID: <Zf2WP1bajI0uytBZ@x1> (raw)
In-Reply-To: <bffa028a3ce0ed157560a96a1f0fc3cc5d707ecb.camel@arm.com>
On Fri, Mar 22, 2024 at 02:18:54PM +0000, Ben Gainey wrote:
> > +++ b/tools/perf/tests/attr/base-record
> > @@ -5,7 +5,7 @@ group_fd=-1
> > flags=0|8
> > cpu=*
> > type=0|1
> > -size=136
> > +size=144
>
> Sigh... this one belongs elsewhere. Too many spinning plates.
>
> I'll have to redo this one with the correct size= value.
It happens, thanks for noticing it and promply reporting, this is _very
much_ appreciated, saves me time. :-)
Just fix it and send a v4.
- Arnaldo
prev parent reply other threads:[~2024-03-22 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 13:04 [PATCH v3 0/4] perf: Support PERF_SAMPLE_READ with inherit_stat Ben Gainey
2024-03-22 13:04 ` [PATCH v3 1/4] " Ben Gainey
2024-03-22 13:04 ` [PATCH v3 2/4] tools/perf: Track where perf_sample_ids need per-thread periods Ben Gainey
2024-03-22 13:04 ` [PATCH v3 3/4] tools/perf: Correctly calculate sample period for inherited SAMPLE_READ values Ben Gainey
2024-03-22 13:04 ` [PATCH v3 4/4] tools/perf: Allow inherit + inherit_stat + PERF_SAMPLE_READ when opening events Ben Gainey
2024-03-22 14:18 ` Ben Gainey
2024-03-22 14:31 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zf2WP1bajI0uytBZ@x1 \
--to=acme@kernel.org \
--cc=Ben.Gainey@arm.com \
--cc=James.Clark@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).