From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0571A38EB; Wed, 13 Mar 2024 20:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710360749; cv=none; b=PGHViAQTsIwjIztrtlwmCmJag/nfMbedGvY75Ik/bH/uv0J8Rq0clTq4+wNDfF1/Waowxvpm961BYzoLVUYCr9qx4onK/jteBAkOQyOX1LaF30190wsX00JlVgJFAsy0S7KMdahamxx4J97OeA1qYUbK2whZsfRjJxW5RIc6vzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710360749; c=relaxed/simple; bh=KmHmCj+Lnzq0QNomtCs32nKQgaqPB7HVxODv8tzQo90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nvAkiJNKab943AlAMQPCmH+wf87MoOeXPk6zs8lKQv8NBo6eO1igxDCAoX8wK4iNS/yuudSypUXeLOkNP9l/e+MFIWl3tTD5QU8ff7/qmHnCOeBJ59dEctLOWbkggipwR36dx/5/eX6x/q1WGx01RH6m2DtM9gjr0PEe+hvw3W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aeyhR+6o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aeyhR+6o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92BB8C433C7; Wed, 13 Mar 2024 20:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710360748; bh=KmHmCj+Lnzq0QNomtCs32nKQgaqPB7HVxODv8tzQo90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aeyhR+6out14XsDJIPLZGZsgI2RlADZ/r3E58+N7EpCHHS92kcKzWK1CoXhDb70oC B6U6VjfB0JPW5ydDZBqtw0f0Ff56OfXAK99bWWvL9FvBVvu3RfYkQoC98O5m8JE3n3 frm7ysGa/3+IAXBBgGRoEANeLQrqANN+5pZRqQKBcbCca7moFUxYgzh4+s2k4XNi/v 92MHYHBAlbdGHkKdlyH+Zn1p+gvG7GZU48b4U5MPswOenwIpcxv31q1qUbkzOA0/+3 Vdm/xl2AATX/yF1DAs0SodIfsNW8Wv+sB3yUWE+P8TaqLUC5qepx/kRMussryDPly4 vGb38XgyeZ/YQ== Date: Wed, 13 Mar 2024 17:12:25 -0300 From: Arnaldo Carvalho de Melo To: Sebastian Andrzej Siewior Cc: Marco Elver , Vince Weaver , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Adrian Hunter , Alexander Shishkin , Ian Rogers , Ingo Molnar , Jiri Olsa , Mark Rutland , Namhyung Kim , Peter Zijlstra , Thomas Gleixner Subject: Re: [PATCH v2 0/4] perf: Make SIGTRAP and __perf_pending_irq() work on RT. Message-ID: References: <20240312180814.3373778-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 13, 2024 at 03:30:52PM -0300, Arnaldo Carvalho de Melo wrote: > On Wed, Mar 13, 2024 at 03:14:28PM -0300, Arnaldo Carvalho de Melo wrote: > > 'perf test' doesn't show any regression, now I'm running Vince Weaver's > > https://github.com/deater/perf_event_tests, storing the results with > > this patchset and then without, to do a diff, lets see... > > So things improved! I'll re-run to see if these results are stable... tldr; No dmesg activity, no kernel splats, most tests passed, nothing noticeable when running with/without the patch with Vince's regression tests. So: Tested-by: Arnaldo Carvalho de Melo Reported-by: Arnaldo Carvalho de Melo - Arnaldo Further details: Without the patch: [root@nine perf_event_tests]# ./run_tests.sh | tee results.$(uname -r).new ; diff -u results.$(uname -r) results.$(uname -r).new --- results.6.8.0-rc7-rt6 2024-03-13 15:26:37.923323518 -0300 +++ results.6.8.0-rc7-rt6.new 2024-03-13 15:32:43.983245095 -0300 @@ -296,7 +296,7 @@ + tests/rdpmc/rdpmc_validation Testing if userspace rdpmc reads give expected results... PASSED + tests/rdpmc/rdpmc_multiplexing - Testing if userspace rdpmc multiplexing works... PASSED + Testing if userspace rdpmc multiplexing works... FAILED + tests/rdpmc/rdpmc_reset Testing if resetting while using rdpmc works... PASSED + tests/rdpmc/rdpmc_group @@ -304,15 +304,15 @@ + tests/rdpmc/rdpmc_attach Testing if rdpmc attach works... PASSED + tests/rdpmc/rdpmc_attach_cpu - Running on CPU 4 + Running on CPU 0 Testing if rdpmc behavior on attach CPU... PASSED + tests/rdpmc/rdpmc_attach_global_cpu - Running on CPU 6 + Running on CPU 3 Testing if rdpmc behavior on attach all procs on other CPU... FAILED + tests/rdpmc/rdpmc_attach_other_cpu - Measuring on CPU 5 -Running on CPU 6 -Measuring on CPU 5 + Measuring on CPU 0 +Running on CPU 3 +Measuring on CPU 0 Testing if rdpmc behavior on attach other CPU... FAILED + tests/rdpmc/rdpmc_multiattach Testing if rdpmc multi-attach works... PASSED A test flipped results. Trying again with a more compact output: [root@nine perf_event_tests]# ./run_tests.sh | tee results.$(uname -r).new ; diff -u results.$(uname -r) results.$(uname -r).new | grep ^[+-] --- results.6.8.0-rc7-rt6 2024-03-13 15:26:37.923323518 -0300 +++ results.6.8.0-rc7-rt6.new 2024-03-13 17:06:34.944149451 -0300 - Running on CPU 4 -Testing if rdpmc behavior on attach CPU... PASSED - + tests/rdpmc/rdpmc_attach_global_cpu +Testing if rdpmc behavior on attach CPU... FAILED + + tests/rdpmc/rdpmc_attach_global_cpu + Running on CPU 0 - Measuring on CPU 5 -Running on CPU 6 -Measuring on CPU 5 + Measuring on CPU 7 +Running on CPU 1 +Measuring on CPU 7 [root@nine perf_event_tests]# Since its that rdpmc that is now always failing without this patch series, lets try using that .new as the new baseline: [root@nine perf_event_tests]# ./run_tests.sh | tee results.$(uname -r).new2 ; diff -u results.$(uname -r).new results.$(uname -r).new2 | grep ^[+-] --- results.6.8.0-rc7-rt6.new 2024-03-13 17:06:34.944149451 -0300 +++ results.6.8.0-rc7-rt6.new2 2024-03-13 17:08:41.438282558 -0300 - Testing "branch-misses" generalized event... FAILED + Testing "branch-misses" generalized event... PASSED - Testing if userspace rdpmc multiplexing works... PASSED + Testing if userspace rdpmc multiplexing works... FAILED - Running on CPU 6 -Testing if rdpmc behavior on attach CPU... FAILED + Running on CPU 2 +Testing if rdpmc behavior on attach CPU... PASSED - Running on CPU 0 + Running on CPU 2 - Measuring on CPU 7 -Running on CPU 1 -Measuring on CPU 7 + Measuring on CPU 2 +Running on CPU 0 +Measuring on CPU 2 [root@nine perf_event_tests]#