From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf script: Show also errors for --insn-trace option
Date: Mon, 18 Mar 2024 18:20:20 -0300 [thread overview]
Message-ID: <ZfiwFB6TpAX90YZf@x1> (raw)
In-Reply-To: <20240315071334.3478-1-adrian.hunter@intel.com>
On Fri, Mar 15, 2024 at 09:13:33AM +0200, Adrian Hunter wrote:
> The trace could be misleading if trace errors are not taken into
> account, so display them also by adding the itrace "e" option.
>
> Note --call-trace and --call-ret-trace already add the itrace "e"
> option.
>
> Fixes: b585ebdb5912 ("perf script: Add --insn-trace for instruction decoding")
> Cc: stable@vger.kernel.org
Thanks, applied both patches to perf-tools-next.
- Arnaldo
prev parent reply other threads:[~2024-03-18 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 7:13 [PATCH 1/2] perf script: Show also errors for --insn-trace option Adrian Hunter
2024-03-15 7:13 ` [PATCH 2/2] perf auxtrace: Fix multiple use of --itrace option Adrian Hunter
2024-03-15 16:44 ` [PATCH 1/2] perf script: Show also errors for --insn-trace option Andi Kleen
2024-03-18 21:20 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfiwFB6TpAX90YZf@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).