linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Petlan <mpetlan@redhat.com>
Cc: vmolnaro@redhat.com, linux-perf-users@vger.kernel.org, acme@redhat.com
Subject: Re: [PATCH v2] perf test record.sh: Raise limit of open file descriptors
Date: Wed, 20 Mar 2024 11:19:30 -0300	[thread overview]
Message-ID: <ZfrwcurxSYKy9uma@x1> (raw)
In-Reply-To: <alpine.LRH.2.20.2403201310220.4040@Diego>

On Wed, Mar 20, 2024 at 01:14:32PM +0100, Michael Petlan wrote:
> Hello Arnaldo,
> kind reminder, any chance this being merged soon?
> Thanks,
> Michael
> 
> On Mon, 11 Mar 2024, vmolnaro@redhat.com wrote:
> > From: Veronika Molnarova <vmolnaro@redhat.com>
> > 
> > Subtest for system-wide record with '--threads=cpu' option fails due
> > to a limit of open file descriptors on systems with 128 or more CPUs
> > as the default limit is set to 1024.
> > 
> > The number of open file descriptors should be slightly above
> > nmb_events*nmb_cpus + nmb_cpus(for perf.data.n) + 4*nmb_cpus(for pipes),
> > which equals 8*nmb_cpus. Therefore, temporarily raise the limit to
> > 16*nmb_cpus for the test.
> >
> > Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
> 
> Acked-by: Michael Petlan <mpetlan@redhat.com>

Its not applying, can you please check?

Please use the
git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
repo, tmp.perf-tools-next branch.

- Arnaldo

⬢[acme@toolbox perf-tools-next]$ b4 am -ctsl --cc-trailers alpine.LRH.2.20.2403201310220.4040@Diego
Grabbing thread from lore.kernel.org/all/alpine.LRH.2.20.2403201310220.4040@Diego/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2] perf test record.sh: Raise limit of open file descriptors
    + Acked-by: Michael Petlan <mpetlan@redhat.com>
    + Link: https://lore.kernel.org/r/20240311081127.7652-1-vmolnaro@redhat.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ---
  NOTE: install dkimpy for DKIM signature verification
---
Total patches: 1
---
 Link: https://lore.kernel.org/r/20240311081127.7652-1-vmolnaro@redhat.com
 Base: not specified
       git am ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
⬢[acme@toolbox perf-tools-next]$ vim ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
⬢[acme@toolbox perf-tools-next]$ patch -p1 < ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
patching file tools/perf/tests/shell/record.sh
Hunk #1 succeeded at 12 with fuzz 2 (offset 1 line).
Hunk #2 FAILED at 162.
1 out of 2 hunks FAILED -- saving rejects to file tools/perf/tests/shell/record.sh.rej
⬢[acme@toolbox perf-tools-next]$ 

  reply	other threads:[~2024-03-20 14:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11  8:11 [PATCH v2] perf test record.sh: Raise limit of open file descriptors vmolnaro
2024-03-20 12:14 ` Michael Petlan
2024-03-20 14:19   ` Arnaldo Carvalho de Melo [this message]
2024-03-28 15:46     ` [PATCH] " vmolnaro
2024-04-25 19:00     ` [PATCH v2] " Arnaldo Carvalho de Melo
2024-04-29  8:53       ` vmolnaro
2024-05-21  9:27         ` Michael Petlan
2024-08-12 13:16           ` Arnaldo Carvalho de Melo
2024-08-12 13:21             ` Arnaldo Carvalho de Melo
2024-08-12 17:02               ` Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2023-11-30 21:42 vmolnaro
2024-01-24 14:31 ` Michael Petlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZfrwcurxSYKy9uma@x1 \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=vmolnaro@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).