From: Ingo Molnar <mingo@kernel.org>
To: Sandipan Das <sandipan.das@amd.com>
Cc: Ian Rogers <irogers@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, peterz@infradead.org, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, tglx@linutronix.de, bp@alien8.de,
eranian@google.com, ravi.bangoria@amd.com,
ananth.narayan@amd.com
Subject: Re: [PATCH 1/2] perf/x86/amd/core: Update stalled-cycles-* events for Zen 2 and later
Date: Tue, 26 Mar 2024 09:05:58 +0100 [thread overview]
Message-ID: <ZgKB5hMlt87E5VhI@gmail.com> (raw)
In-Reply-To: <5749c648-b6c4-4400-9628-3cd38d953f58@amd.com>
* Sandipan Das <sandipan.das@amd.com> wrote:
> On 3/25/2024 8:04 PM, Ian Rogers wrote:
> > On Mon, Mar 25, 2024 at 12:48 AM Sandipan Das <sandipan.das@amd.com> wrote:
> >>
> >> AMD processors based on Zen 2 and later microarchitectures do not
> >> support PMCx087 (instruction pipe stalls) which is used as the backing
> >> event for "stalled-cycles-frontend" and "stalled-cycles-backend". Use
> >> PMCx0A9 (cycles where micro-op queue is empty) instead to count frontend
> >> stalls and remove the entry for backend stalls since there is no direct
> >> replacement.
> >>
> >> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> >
> > This looks good to me. Should there be a Fixes tag for the sake of backports?
> >
>
> My bad. Yes, there should a fixes tag.
>
> Fixes: 3fe3331bb285 ("perf/x86/amd: Add event map for AMD Family 17h")
>
> Ingo, I see that you have already pushed this to the perf/urgent branch.
> Should I send a v2?
That's OK, no need, I've amended the commits in perf/urgent. 2019 is quite
a way back for a Fixes tag though. :-)
Thanks,
Ingo
next prev parent reply other threads:[~2024-03-26 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 7:47 [PATCH 0/2] perf/x86/amd: Update generalized events Sandipan Das
2024-03-25 7:47 ` [PATCH 1/2] perf/x86/amd/core: Update stalled-cycles-* events for Zen 2 and later Sandipan Das
2024-03-25 14:34 ` Ian Rogers
2024-03-26 6:02 ` Sandipan Das
2024-03-26 8:05 ` Ingo Molnar [this message]
2024-03-25 7:47 ` [PATCH 2/2] perf/x86/amd/core: Add ref-cycles event for Zen 4 " Sandipan Das
2024-03-25 14:43 ` Ian Rogers
2024-03-26 6:16 ` Sandipan Das
2024-03-26 17:12 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgKB5hMlt87E5VhI@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).