From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Changbin Du <changbin.du@huawei.com>
Subject: Re: [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler
Date: Fri, 29 Mar 2024 14:09:41 -0300 [thread overview]
Message-ID: <Zgb1uj_VQ1pjFdKE@x1> (raw)
In-Reply-To: <20240328232009.466018-1-namhyung@kernel.org>
On Thu, Mar 28, 2024 at 04:20:05PM -0700, Namhyung Kim wrote:
> Hello,
>
> As we've added libcapstone support, it's natural to use it for perf annotate
> as well. This change added the capstone support on x86 first. Other archs
> can be added later (by someone who can verify it doesn't break things).
>
> For now it tries to use capstone (if available) before objdump. But it
> doesn't support source file and line number info. So users should use the
> objdump (by passing --objdump=PATH option) if they need them. For example,
> this command line will keep the existing behavior (i.e. using objdump).
>
> # not to use capstone for disassembly
> $ perf annotate --objdump=objdump
>
> The capstone uses LLVM objdump style output which is slightly different than
> the GNU objdump. But it should not have differences besides that. I've
> verified the result of data type profiling and it produced the same output
> but gave me ~3x speedups.
Excellent news, I'll try and test all this soon!
- Arnaldo
prev parent reply other threads:[~2024-03-29 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 23:20 [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler Namhyung Kim
2024-03-28 23:20 ` [PATCH 1/4] perf annotate: Use ins__is_xxx() if possible Namhyung Kim
2024-03-28 23:20 ` [PATCH 2/4] perf annotate: Add and use ins__is_nop() Namhyung Kim
2024-03-28 23:20 ` [PATCH 3/4] perf annotate: Split out util/disasm.c Namhyung Kim
2024-03-28 23:20 ` [PATCH 4/4] perf annotate: Use libcapstone to disassemble Namhyung Kim
2024-03-29 16:32 ` [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler Ian Rogers
2024-03-29 19:57 ` Namhyung Kim
2024-03-29 17:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgb1uj_VQ1pjFdKE@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).