From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf annotate: Get rid of duplicate --group option item
Date: Tue, 2 Apr 2024 17:40:09 -0300 [thread overview]
Message-ID: <ZgxtKVSwAbFXK01k@x1> (raw)
In-Reply-To: <9cfa43c3-3698-455c-8a2f-85c30470733c@linux.intel.com>
On Mon, Mar 25, 2024 at 09:56:50AM -0400, Liang, Kan wrote:
>
>
> On 2024-03-22 6:43 p.m., Namhyung Kim wrote:
> > The options array in cmd_annotate() has duplicate --group options. It
> > only needs one and let's get rid of the other.
> >
> > $ perf annotate -h 2>&1 | grep group
> > --group Show event group information together
> > --group Show event group information together
> >
> > Fixes: 7ebaf4890f63 ("perf annotate: Support '--group' option")
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> For the series,
>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
For 'b4' sake, next time please send the Reviewed-by to the cover letter
in the series so that it picks your Reviewed-by for all patches, not
just for the one that you replied to, as in this case.
I'm adding it to this whole series,
Thanks!
- Arnaldo
prev parent reply other threads:[~2024-04-02 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 22:43 [PATCH 1/2] perf annotate: Get rid of duplicate --group option item Namhyung Kim
2024-03-22 22:43 ` [PATCH 2/2] perf annotate: Honor output options with --data-type Namhyung Kim
2024-03-25 13:56 ` [PATCH 1/2] perf annotate: Get rid of duplicate --group option item Liang, Kan
2024-04-02 20:40 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgxtKVSwAbFXK01k@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).