From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 138E584DE1; Fri, 12 Apr 2024 19:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712950532; cv=none; b=HtCUgvpQQdSvtX80Cc908yHAo6V5v2uTyetE0GzVCOEzkQtSJTJH/VdSLCrL5PH5W4BHF1oM2bTdU+N7QqEf9MbnWfEfFxdBSQoTjFwpGIeDAsCc+Xzu/SEyfSV3FAObVUu2ml4+ltydjf378VNoVqVBSw+CmFqxCrniMKeTNFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712950532; c=relaxed/simple; bh=ofVVy4zferD+RNPrdaRnvyrBwq7zff5WYyjwpk4ktSY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PuukcwaS7oqp2wn9mIdhSBxQA7XtIq/y+HUr4lG+/6UNrF8z56DE3jkb/is6AhEDbgRsag0V2PBPjuxAUmXI7HIGrTW7lS6YaKjgZaLDMSm5XjtOg1DuLU+F0tlgrfKSt+w8NDqU10+hbuIkQ/KDoNhRjXZmUp2/c0jS8uf1Kl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cpwJTI4i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cpwJTI4i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15CC7C113CC; Fri, 12 Apr 2024 19:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712950531; bh=ofVVy4zferD+RNPrdaRnvyrBwq7zff5WYyjwpk4ktSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cpwJTI4itTVfMiJUAOaybYNjldBMEvIp9h9tBGn60Kgn9Loqjmt4XdA5pgDeSlzpr UGcd2U1xM+oSLRjKs71liI3qDqECEGzQUwzYZQwMWx4y3zRPvuSBFAjB2QV8mSK21g HUrvb/GII4suEGh113rDQ2KxVXlv07Sa4QllDSSbwCmC+0pgBSnYwd7xejC5rNBqvO 6K3EXjyk/9Gh0sFert6VdVwGrqNCsGWBN2Y1qT26TLsZvbB2xvZC8Xx9CbrZeLfjfs JXpeCmDsZtzp71VYw/dqSenJUY+UMKZ2AMv8Thi74mvCIETUmnvuUj6IrUQiU6cPhk /lGx3S6BuF7tA== Date: Fri, 12 Apr 2024 16:35:28 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] perf list: Esacpe \r in json output Message-ID: References: <20240410222353.1722840-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410222353.1722840-1-irogers@google.com> On Wed, Apr 10, 2024 at 03:23:53PM -0700, Ian Rogers wrote: > Events like for sapphirerapids have \r in the uncore descriptions. The > non-escaped versions of this fail json validation the the perf list > test. Thanks, applied to perf-tools-next, - Arnaldo > Signed-off-by: Ian Rogers > --- > tools/perf/builtin-list.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > index 02bf608d585e..9333cc64c2ce 100644 > --- a/tools/perf/builtin-list.c > +++ b/tools/perf/builtin-list.c > @@ -313,6 +313,9 @@ static void fix_escape_fprintf(FILE *fp, struct strbuf *buf, const char *fmt, .. > case '\n': > strbuf_addstr(buf, "\\n"); > break; > + case '\r': > + strbuf_addstr(buf, "\\r"); > + break; > case '\\': > fallthrough; > case '\"': > -- > 2.44.0.478.gd926399ef9-goog