Re: [PATCH v2] perf test record.sh: Raise limit of open file descriptors

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Mar 20, 2024 at 11:19:30AM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Mar 20, 2024 at 01:14:32PM +0100, Michael Petlan wrote:
> > Hello Arnaldo,
> > kind reminder, any chance this being merged soon?
> > Thanks,
> > Michael
> > 
> > On Mon, 11 Mar 2024, vmolnaro@redhat.com wrote:
> > > From: Veronika Molnarova <vmolnaro@redhat.com>
> > > 
> > > Subtest for system-wide record with '--threads=cpu' option fails due
> > > to a limit of open file descriptors on systems with 128 or more CPUs
> > > as the default limit is set to 1024.
> > > 
> > > The number of open file descriptors should be slightly above
> > > nmb_events*nmb_cpus + nmb_cpus(for perf.data.n) + 4*nmb_cpus(for pipes),
> > > which equals 8*nmb_cpus. Therefore, temporarily raise the limit to
> > > 16*nmb_cpus for the test.
> > >
> > > Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
> > 
> > Acked-by: Michael Petlan <mpetlan@redhat.com>
> 
> Its not applying, can you please check?
> 
> Please use the
> git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
> repo, tmp.perf-tools-next branch.

ping?

- Arnaldo
 
> - Arnaldo
> 
> ⬢[acme@toolbox perf-tools-next]$ b4 am -ctsl --cc-trailers alpine.LRH.2.20.2403201310220.4040@Diego
> Grabbing thread from lore.kernel.org/all/alpine.LRH.2.20.2403201310220.4040@Diego/t.mbox.gz
> Checking for newer revisions
> Grabbing search results from lore.kernel.org
> Analyzing 2 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   [PATCH v2] perf test record.sh: Raise limit of open file descriptors
>     + Acked-by: Michael Petlan <mpetlan@redhat.com>
>     + Link: https://lore.kernel.org/r/20240311081127.7652-1-vmolnaro@redhat.com
>     + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>   ---
>   NOTE: install dkimpy for DKIM signature verification
> ---
> Total patches: 1
> ---
>  Link: https://lore.kernel.org/r/20240311081127.7652-1-vmolnaro@redhat.com
>  Base: not specified
>        git am ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
> ⬢[acme@toolbox perf-tools-next]$ vim ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
> ⬢[acme@toolbox perf-tools-next]$ patch -p1 < ./v2_20240311_vmolnaro_perf_test_record_sh_raise_limit_of_open_file_descriptors.mbx
> patching file tools/perf/tests/shell/record.sh
> Hunk #1 succeeded at 12 with fuzz 2 (offset 1 line).
> Hunk #2 FAILED at 162.
> 1 out of 2 hunks FAILED -- saving rejects to file tools/perf/tests/shell/record.sh.rej
> ⬢[acme@toolbox perf-tools-next]$