From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Changbin Du <changbin.du@huawei.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/4] perf map: Add missing dso__put in map__new
Date: Mon, 6 May 2024 15:36:08 -0300 [thread overview]
Message-ID: <ZjkjGL6krayHC_XX@x1> (raw)
In-Reply-To: <20240506180104.485674-2-irogers@google.com>
On Mon, May 06, 2024 at 11:01:01AM -0700, Ian Rogers wrote:
> A dso__put is needed for the dsos__find when the map is created and a
> buildid is sought.
> Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking")
I just sent a reply asking you to do this, thanks a lot for adding the
Fixes tag, processing this new series now.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/map.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index 117c4bb78b35..e1d14936a60d 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -200,6 +200,7 @@ struct map *map__new(struct machine *machine, u64 start, u64 len,
> dso__set_build_id(dso, dso__bid(header_bid_dso));
> dso__set_header_build_id(dso, 1);
> }
> + dso__put(header_bid_dso);
> }
> dso__put(dso);
> }
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>
next prev parent reply other threads:[~2024-05-06 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 18:01 [PATCH v7 0/4] dso/dsos memory savings and clean up Ian Rogers
2024-05-06 18:01 ` [PATCH v7 1/4] perf map: Add missing dso__put in map__new Ian Rogers
2024-05-06 18:36 ` Arnaldo Carvalho de Melo [this message]
2024-05-06 18:01 ` [PATCH v7 2/4] perf symbol-elf: Ensure dso__put in machine__process_ksymbol_register Ian Rogers
2024-05-06 18:01 ` [PATCH v7 3/4] perf symbol-elf: dso__load_sym_internal reference count fixes Ian Rogers
2024-05-06 18:01 ` [PATCH v7 4/4] perf dso: Use container_of to avoid a pointer in dso_data Ian Rogers
2024-05-06 20:36 ` [PATCH v7 0/4] dso/dsos memory savings and clean up Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjkjGL6krayHC_XX@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=changbin.du@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).