From: Dominique Martinet <asmadeus@codewreck.org>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] perf parse-events: pass parse_state to add_tracepoint
Date: Thu, 9 May 2024 08:03:49 +0900 [thread overview]
Message-ID: <ZjwE1dVbJVUN34dP@codewreck.org> (raw)
In-Reply-To: <CAP-5=fWRLcsgMvBJnJNBt1k1O8vDqk2O6V2v2k7Jf3nY=yA+cQ@mail.gmail.com> <CAP-5=fUmeyd3BR7njJEDQ-=qkpvLPMoQO-7De+3mqLaSOoZZxw@mail.gmail.com>
Thanks for the review!
Ian Rogers wrote on Wed, May 08, 2024 at 02:37:16PM -0700:
> Nit: evsel__newtp_idx typo
Fixed in v3
> Fwiw, I think the idx value is possibly something to be done away
> with. We renumber the evsels here:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/parse-events.c?h=perf-tools-next#n2077
(I'm not sure what's immediately actionable here, so I'll consider this
a higher level comment for later cleanup)
Ian Rogers wrote on Wed, May 08, 2024 at 03:47:29PM -0700:
> Note, this isn't applying cleanly to the perf-tools-next branch on:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/
Thanks for this note, I've rebased on this branch for v3
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2024-05-08 23:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 11:13 [PATCH v2 0/3] perf probe: Allow names to start with digits Dominique Martinet
2024-05-05 11:13 ` [PATCH v2 1/3] perf parse-events: pass parse_state to add_tracepoint Dominique Martinet
2024-05-08 21:37 ` Ian Rogers
2024-05-08 23:03 ` Dominique Martinet [this message]
2024-05-09 21:24 ` Arnaldo Carvalho de Melo
2024-05-09 21:46 ` Arnaldo Carvalho de Melo
2024-05-09 21:59 ` Dominique Martinet
2024-05-05 11:13 ` [PATCH v2 2/3] perf parse-events: Add new 'fake_tp' parameter for tests Dominique Martinet
2024-05-08 21:42 ` Ian Rogers
2024-05-05 11:13 ` [PATCH v2 3/3] perf parse: Allow names to start with digits Dominique Martinet
2024-05-08 21:44 ` Ian Rogers
2024-05-08 22:47 ` [PATCH v2 0/3] perf probe: " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjwE1dVbJVUN34dP@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).