From: "Steinar H. Gunderson" <sesse@google.com>
To: Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] perf report: Support LLVM for addr2line()
Date: Sun, 19 May 2024 23:01:05 +0200 [thread overview]
Message-ID: <ZkpokaHRfQYCo3uG@google.com> (raw)
In-Reply-To: <CAP-5=fW5YtzYz0R-9ZkgfdAFjkUDHu_Z1Sexs+2SmN0RwhrADw@mail.gmail.com>
On Sun, May 19, 2024 at 11:23:26AM -0700, Ian Rogers wrote:
> I think we might want to display this in the feature list during the build:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/build/Makefile.feature?h=perf-tools-next#n123
Ack.
> s/HAVE_LIBLLVM_SUPPORT/HAVE_LLVM_SUPPORT/
Ack.
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wunused-parameter" /* Needed for LLVM 14. */
> nit: pehaps disabling this should be conditional:
> #if LLVM_VERSION_MAJOR == 14
It doesn't seem LLVM_VERSION_MAJOR is defined yet at this point, so I
don't think that would work. (I just checked; 15 has the same issue.)
In any case, I think it would be just more clutter for dubious gain.
>> + if (file) {
>> + if (line_info.FileName == "<invalid>") {
>> + /* Match the convention of libbfd. */
>> + *file = nullptr;
> Should "*file" be cleared if "!file" so the caller can reliably free it?
I don't understand. If “!file”, then file == NULL and surely accessing
*file would mean a crash?
/* Steinar */
next prev parent reply other threads:[~2024-05-19 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 16:53 [PATCH v2 1/3] perf report: Support LLVM for addr2line() Steinar H. Gunderson
2024-05-18 16:53 ` [PATCH v2 2/3] perf annotate: split out read_symbol() Steinar H. Gunderson
2024-05-18 16:53 ` [PATCH v2 3/3] perf annotate: LLVM-based disassembler Steinar H. Gunderson
2024-05-19 18:23 ` [PATCH v2 1/3] perf report: Support LLVM for addr2line() Ian Rogers
2024-05-19 21:01 ` Steinar H. Gunderson [this message]
2024-05-19 23:00 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkpokaHRfQYCo3uG@google.com \
--to=sesse@google.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).