Re: [PATCH] perf script: netdev-times: add location parameter to consume_skb

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Jun 05, 2024 at 04:44:42PM +0200, Lucas Stach wrote:
> dd1b527831a3 ("net: add location to trace_consume_skb()") added a new
> parameter to the consume_skb tracepoint. Adapt the script to match.

From what I could see from
tools/perf/util/scripting-engines/trace-event-python.c this will work
with older kernels where this tracepoint field isn't available, but
since I haven't actually tested this with an old kernel without it:

Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Thanks,

- Arnaldo


> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  tools/perf/scripts/python/netdev-times.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/scripts/python/netdev-times.py b/tools/perf/scripts/python/netdev-times.py
> index 00552eeb7178..30c4bccee5b2 100644
> --- a/tools/perf/scripts/python/netdev-times.py
> +++ b/tools/perf/scripts/python/netdev-times.py
> @@ -293,7 +293,8 @@ def skb__kfree_skb(name, context, cpu, sec, nsec, pid, comm, callchain,
>  			skbaddr, location, protocol, reason)
>  	all_event_list.append(event_info)
>  
> -def skb__consume_skb(name, context, cpu, sec, nsec, pid, comm, callchain, skbaddr):
> +def skb__consume_skb(name, context, cpu, sec, nsec, pid, comm, callchain,
> +			skbaddr, location):
>  	event_info = (name, context, cpu, nsecs(sec, nsec), pid, comm,
>  			skbaddr)
>  	all_event_list.append(event_info)
> -- 
> 2.45.1
>