From: Namhyung Kim <namhyung@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, james.clark@arm.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf pmu: Remove unneeded semicolon
Date: Tue, 2 Jul 2024 16:51:56 -0700 [thread overview]
Message-ID: <ZoSSnBBXr5kb_zv3@google.com> (raw)
In-Reply-To: <20240701034300.558886-1-nichen@iscas.ac.cn>
Hello,
On Mon, Jul 01, 2024 at 11:43:00AM +0800, Chen Ni wrote:
> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Fixes: d9c5f5f94c2d ("perf pmu: Count sys and cpuid JSON events separately")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Thanks for the fix but it's already fixed.
https://lore.kernel.org/linux-perf-users/20240628053049.44521-1-yang.lee@linux.alibaba.com/
Namhyung
> ---
> tools/perf/util/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index c94a91645b21..884eb23445e4 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -1773,7 +1773,7 @@ size_t perf_pmu__num_events(struct perf_pmu *pmu)
> size_t nr;
>
> pmu_aliases_parse(pmu);
> - nr = pmu->sysfs_aliases + pmu->sys_json_aliases;;
> + nr = pmu->sysfs_aliases + pmu->sys_json_aliases;
>
> if (pmu->cpu_aliases_added)
> nr += pmu->cpu_json_aliases;
> --
> 2.25.1
>
prev parent reply other threads:[~2024-07-02 23:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 3:43 [PATCH] perf pmu: Remove unneeded semicolon Chen Ni
2024-07-02 23:51 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoSSnBBXr5kb_zv3@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nichen@iscas.ac.cn \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).