linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 1/2] perf script: Fix perf script -F +metric
Date: Mon, 15 Jul 2024 20:33:26 -0700	[thread overview]
Message-ID: <ZpXqBqxUt8khEqgz@tassilo> (raw)
In-Reply-To: <DA123DCE-7607-45A8-987B-34F42B3D9E7B@linux.vnet.ibm.com>

> I tested this on powerpc.  It fails.
> Version 4 had worked for me. But version 5 fails with segfault

Thanks for testing. Looks like this fix is cursed. And clearly my perf
test runs are still not working. I usually try to avoid installing perf,
but you have set some symlinks manually and use a special directory
for the shell test to work and that is not reliable here.

I guess we can exclude the two cases for now (perf stat record vs -F +metric), 
although it would be better to make metrics work in both cases.
But changing the stat code to support multiple aggregations at the same
time is too much. Maybe if the perf metric code could also use
AGGR_NONE, but I don't know how to make that work.

-Andi

  reply	other threads:[~2024-07-16  3:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-13 15:54 [PATCH v5 1/2] perf script: Fix perf script -F +metric Andi Kleen
2024-07-13 15:54 ` [PATCH v5 2/2] Add a test case for " Andi Kleen
2024-07-13 18:02 ` [PATCH v5 1/2] perf script: Fix " Athira Rajeev
2024-07-16  3:33   ` Andi Kleen [this message]
2024-07-16  5:58     ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpXqBqxUt8khEqgz@tassilo \
    --to=ak@linux.intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).