From: Andi Kleen <ak@linux.intel.com>
To: James Clark <james.clark@linaro.org>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: Re: [PATCH v1 2/2] perf script: Fix for `perf script +F metric` with leader sampling
Date: Tue, 23 Jul 2024 08:39:58 -0700 [thread overview]
Message-ID: <Zp_Ozo_Iyu1sgL9h@tassilo> (raw)
In-Reply-To: <945e58b5-5012-45a8-933a-c1a192fd006e@linaro.org>
> Yeah I suppose it's strictly better now without the segfault. Could you pull
> in the test and update it to add -a? At least then that behavior will be
> locked down and we can extend it later without -a.
Ian's patch really implements completely new functionality (supporting
metrics over multiple groups). It isn't a regression fix, but completely
redesigns the old "single group" feature.
> I also tested Andi's V5 and still got the segfault.
Yes the earlier versions worked, but they broke perf stat report.
I think the right short term fix is to use V3 or so, but with a
check that perf stat report isn't used.
Then perhaps the new functionality of multiple groups can be considered
over it.
-Andi
next prev parent reply other threads:[~2024-07-23 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 7:45 [PATCH v1 1/2] libperf threadmap: Add ability to find index from pid Ian Rogers
2024-07-20 7:45 ` [PATCH v1 2/2] perf script: Fix for `perf script +F metric` with leader sampling Ian Rogers
2024-07-23 14:41 ` James Clark
2024-07-23 14:57 ` Ian Rogers
2024-07-23 15:26 ` Andi Kleen
2024-07-23 15:26 ` James Clark
2024-07-23 15:39 ` Andi Kleen [this message]
2024-07-23 15:49 ` Ian Rogers
2024-07-26 0:05 ` Namhyung Kim
2024-07-26 3:32 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp_Ozo_Iyu1sgL9h@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).