linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steinar H. Gunderson" <sesse@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, irogers@google.com,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v8 1/3] perf report: Support LLVM for addr2line()
Date: Fri, 19 Jul 2024 17:00:26 +0200	[thread overview]
Message-ID: <Zpp_iiovOlsLQmQ7@google.com> (raw)
In-Reply-To: <ZmCi3Z940zDxF487@google.com>

On Wed, Jun 05, 2024 at 10:39:41AM -0700, Namhyung Kim wrote:
> Please fix the coding style.  Also you may add a pair of brackets to
> multi-line code even if it's a single statement.

Fixed (I think?). Sending out a v9 also with added build test plus a fix
for /usr/include/llvm-c not existing.

/* Steinar */

      reply	other threads:[~2024-07-19 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02 20:42 [PATCH v8 1/3] perf report: Support LLVM for addr2line() Steinar H. Gunderson
2024-06-02 20:42 ` [PATCH v8 2/3] perf annotate: split out read_symbol() Steinar H. Gunderson
2024-06-02 20:42 ` [PATCH v8 3/3] perf annotate: LLVM-based disassembler Steinar H. Gunderson
2024-06-05  1:10   ` Namhyung Kim
2024-06-05 17:39 ` [PATCH v8 1/3] perf report: Support LLVM for addr2line() Namhyung Kim
2024-07-19 15:00   ` Steinar H. Gunderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zpp_iiovOlsLQmQ7@google.com \
    --to=sesse@google.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).