public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 3/4] perf script: Fix perf script -F +metric
Date: Tue, 23 Jul 2024 17:36:52 -0700	[thread overview]
Message-ID: <ZqBMpElyYfjyf8xq@tassilo> (raw)
In-Reply-To: <CAP-5=fUrw3W-v53zi4xo9NVh=-fjXrNr3FC=KQFWj1E+ckZN9A@mail.gmail.com>

> The main reason would be so that perf_stat_process_counter could work
> and update the aggregation accordingly. Then you can dump out the
> aggregation, be it per CPU, per core, per socket, per cache-level,
> etc. as appropriate. 

But there's is none. It's only for a short time on a single CPU.

> If you follow the perf stat convention you are
> also much less likely to be broken in the future, as perf stat would
> also get broken. It is complicated spaghetti to work out how this
> stuff works, but that's why I fixed in the patch I sent out.

Hopefully the regression tests will prevent future breakage.

> Or let it set the aggregation mode and just let the aggregation code
> handle it when computing metrics? I think getting the STAT events
> isn't typical, so this is an academic argument.

I don't see why users shouldn't use perf stat record. It makes
sense for any large scale count collections. And it's tested by
the test suite at least.

-Andi

  reply	other threads:[~2024-07-24  0:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 20:48 [PATCH v6 1/4] Create source symlink in perf object dir Andi Kleen
2024-07-23 20:48 ` [PATCH v6 2/4] perf test: Support external tests for separate objdir Andi Kleen
2024-07-23 20:48 ` [PATCH v6 3/4] perf script: Fix perf script -F +metric Andi Kleen
2024-07-23 21:32   ` Ian Rogers
2024-07-23 23:29     ` Andi Kleen
2024-07-24  0:05       ` Ian Rogers
2024-07-24  0:36         ` Andi Kleen [this message]
2024-07-23 20:48 ` [PATCH v6 4/4] Add a test case for " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqBMpElyYfjyf8xq@tassilo \
    --to=ak@linux.intel.com \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox