From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: James Clark <james.clark@linaro.org>,
coresight@lists.linaro.org, gankulkarni@os.amperecomputing.com,
leo.yan@arm.com, suzuki.poulose@arm.com,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] perf cs-etm: Output 0 instead of 0xdeadbeef when exception packets are flushed
Date: Fri, 26 Jul 2024 11:35:15 -0300 [thread overview]
Message-ID: <ZqO0I1zLFX_oLYaY@x1> (raw)
In-Reply-To: <CAJ9a7VhLx0Zi0e-1qzcGCUWArkeD7vDkv0ewueDE_pYbmm5PVw@mail.gmail.com>
On Tue, Jul 23, 2024 at 04:09:29PM +0100, Mike Leach wrote:
> On Mon, 22 Jul 2024 at 16:28, James Clark <james.clark@linaro.org> wrote:
> >
> > Normally exception packets don't directly output a branch sample, but
> > if they're the last record in a buffer then they will. Because they
> > don't have addresses set we'll see the placeholder value
> > CS_ETM_INVAL_ADDR (0xdeadbeef) in the output.
> >
> > Since commit 6035b6804bdf ("perf cs-etm: Support dummy address value for
> > CS_ETM_TRACE_ON packet") we've used 0 as an externally visible "not set"
> > address value. For consistency reasons and to not make exceptions look
> > like an error, change them to use 0 too.
<SNIP>
> Reviewed-by: Mike Leach <mike.leach@linaro.org>
Thanks, applied to tmp.perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-07-26 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 15:27 [PATCH 0/1] perf cs-etm: Output 0 instead of 0xdeadbeef when exception packets are flushed James Clark
2024-07-22 15:27 ` [PATCH 1/1] " James Clark
2024-07-23 15:09 ` Mike Leach
2024-07-26 14:35 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqO0I1zLFX_oLYaY@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gankulkarni@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).