* [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode
@ 2024-07-23 13:28 James Clark
2024-07-23 16:05 ` Leo Yan
0 siblings, 1 reply; 3+ messages in thread
From: James Clark @ 2024-07-23 13:28 UTC (permalink / raw)
To: coresight, gankulkarni, mike.leach, leo.yan, suzuki.poulose
Cc: James Clark, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Ruidong Tian, Benjamin Gray, linux-perf-users,
linux-kernel
The linked commit moved the early return on the first sample to before
the verbose log, so move the log earlier too. Now the first sample is
also logged and not skipped.
Fixes: 2d98dbb4c9c5 ("perf scripts python arm-cs-trace-disasm.py: Do not ignore disam first sample")
Signed-off-by: James Clark <james.clark@linaro.org>
---
tools/perf/scripts/python/arm-cs-trace-disasm.py | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
index d973c2baed1c..7aff02d84ffb 100755
--- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
+++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
@@ -192,17 +192,16 @@ def process_event(param_dict):
ip = sample["ip"]
addr = sample["addr"]
+ if (options.verbose == True):
+ print("Event type: %s" % name)
+ print_sample(sample)
+
# Initialize CPU data if it's empty, and directly return back
# if this is the first tracing event for this CPU.
if (cpu_data.get(str(cpu) + 'addr') == None):
cpu_data[str(cpu) + 'addr'] = addr
return
-
- if (options.verbose == True):
- print("Event type: %s" % name)
- print_sample(sample)
-
# If cannot find dso so cannot dump assembler, bail out
if (dso == '[unknown]'):
return
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode
2024-07-23 13:28 [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode James Clark
@ 2024-07-23 16:05 ` Leo Yan
2024-07-26 14:36 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Leo Yan @ 2024-07-23 16:05 UTC (permalink / raw)
To: James Clark, coresight, gankulkarni, mike.leach, suzuki.poulose
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan, Ruidong Tian,
Benjamin Gray, linux-perf-users, linux-kernel
On 7/23/2024 2:28 PM, James Clark wrote:
>
> The linked commit moved the early return on the first sample to before
> the verbose log, so move the log earlier too. Now the first sample is
> also logged and not skipped.
>
> Fixes: 2d98dbb4c9c5 ("perf scripts python arm-cs-trace-disasm.py: Do not ignore disam first sample")
> Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Leo Yan <leo.yan@arm.com>
> ---
> tools/perf/scripts/python/arm-cs-trace-disasm.py | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> index d973c2baed1c..7aff02d84ffb 100755
> --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
> +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> @@ -192,17 +192,16 @@ def process_event(param_dict):
> ip = sample["ip"]
> addr = sample["addr"]
>
> + if (options.verbose == True):
> + print("Event type: %s" % name)
> + print_sample(sample)
> +
> # Initialize CPU data if it's empty, and directly return back
> # if this is the first tracing event for this CPU.
> if (cpu_data.get(str(cpu) + 'addr') == None):
> cpu_data[str(cpu) + 'addr'] = addr
> return
>
> -
> - if (options.verbose == True):
> - print("Event type: %s" % name)
> - print_sample(sample)
> -
> # If cannot find dso so cannot dump assembler, bail out
> if (dso == '[unknown]'):
> return
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode
2024-07-23 16:05 ` Leo Yan
@ 2024-07-26 14:36 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-07-26 14:36 UTC (permalink / raw)
To: Leo Yan
Cc: James Clark, coresight, gankulkarni, mike.leach, suzuki.poulose,
Peter Zijlstra, Ingo Molnar, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Ruidong Tian, Benjamin Gray, linux-perf-users,
linux-kernel
On Tue, Jul 23, 2024 at 05:05:09PM +0100, Leo Yan wrote:
> On 7/23/2024 2:28 PM, James Clark wrote:
> >
> > The linked commit moved the early return on the first sample to before
> > the verbose log, so move the log earlier too. Now the first sample is
> > also logged and not skipped.
> >
> > Fixes: 2d98dbb4c9c5 ("perf scripts python arm-cs-trace-disasm.py: Do not ignore disam first sample")
> > Signed-off-by: James Clark <james.clark@linaro.org>
>
> Reviewed-by: Leo Yan <leo.yan@arm.com>
Thanks, applied to tmp.perf-tools-next,
- Arnaldo
> > ---
> > tools/perf/scripts/python/arm-cs-trace-disasm.py | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> > index d973c2baed1c..7aff02d84ffb 100755
> > --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
> > +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> > @@ -192,17 +192,16 @@ def process_event(param_dict):
> > ip = sample["ip"]
> > addr = sample["addr"]
> >
> > + if (options.verbose == True):
> > + print("Event type: %s" % name)
> > + print_sample(sample)
> > +
> > # Initialize CPU data if it's empty, and directly return back
> > # if this is the first tracing event for this CPU.
> > if (cpu_data.get(str(cpu) + 'addr') == None):
> > cpu_data[str(cpu) + 'addr'] = addr
> > return
> >
> > -
> > - if (options.verbose == True):
> > - print("Event type: %s" % name)
> > - print_sample(sample)
> > -
> > # If cannot find dso so cannot dump assembler, bail out
> > if (dso == '[unknown]'):
> > return
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-26 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 13:28 [PATCH] perf scripts python: cs-etm: Restore first sample log in verbose mode James Clark
2024-07-23 16:05 ` Leo Yan
2024-07-26 14:36 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).