linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
	peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf daemon: Convert comma to semicolon
Date: Fri, 26 Jul 2024 11:14:05 -0300	[thread overview]
Message-ID: <ZqOvLekXEZgu6Hqo@x1> (raw)
In-Reply-To: <CAP-5=fXn_0oudWiVgJ7pgi7GW65HrNOVaAg71c+JjfDnkK1cAw@mail.gmail.com>

On Tue, Jul 16, 2024 at 06:33:34AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to tmp.perf-tools-next, and also removed the fixes tag.

- Arnaldo
 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/builtin-daemon.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> > index de76bbc50bfb..18f7f417ba11 100644
> > --- a/tools/perf/builtin-daemon.c
> > +++ b/tools/perf/builtin-daemon.c
> > @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
> >         }
> >
> >         memset(&cmd, 0, sizeof(cmd));
> > -       cmd.signal.cmd = CMD_SIGNAL,
> > +       cmd.signal.cmd = CMD_SIGNAL;
> >         cmd.signal.sig = SIGUSR2;
> >         strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
> >
> > --
> > 2.25.1
> >

      reply	other threads:[~2024-07-26 14:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  7:43 [PATCH] perf daemon: Convert comma to semicolon Chen Ni
2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:14   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqOvLekXEZgu6Hqo@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).