* [PATCH] perf daemon: Convert comma to semicolon
@ 2024-07-16 7:43 Chen Ni
2024-07-16 13:33 ` Ian Rogers
0 siblings, 1 reply; 3+ messages in thread
From: Chen Ni @ 2024-07-16 7:43 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang
Cc: linux-perf-users, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
tools/perf/builtin-daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
index de76bbc50bfb..18f7f417ba11 100644
--- a/tools/perf/builtin-daemon.c
+++ b/tools/perf/builtin-daemon.c
@@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
}
memset(&cmd, 0, sizeof(cmd));
- cmd.signal.cmd = CMD_SIGNAL,
+ cmd.signal.cmd = CMD_SIGNAL;
cmd.signal.sig = SIGUSR2;
strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf daemon: Convert comma to semicolon
2024-07-16 7:43 [PATCH] perf daemon: Convert comma to semicolon Chen Ni
@ 2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:14 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2024-07-16 13:33 UTC (permalink / raw)
To: Chen Ni
Cc: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, adrian.hunter, kan.liang, linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/builtin-daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> index de76bbc50bfb..18f7f417ba11 100644
> --- a/tools/perf/builtin-daemon.c
> +++ b/tools/perf/builtin-daemon.c
> @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
> }
>
> memset(&cmd, 0, sizeof(cmd));
> - cmd.signal.cmd = CMD_SIGNAL,
> + cmd.signal.cmd = CMD_SIGNAL;
> cmd.signal.sig = SIGUSR2;
> strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf daemon: Convert comma to semicolon
2024-07-16 13:33 ` Ian Rogers
@ 2024-07-26 14:14 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-07-26 14:14 UTC (permalink / raw)
To: Ian Rogers
Cc: Chen Ni, peterz, mingo, namhyung, mark.rutland,
alexander.shishkin, jolsa, adrian.hunter, kan.liang,
linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 06:33:34AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to tmp.perf-tools-next, and also removed the fixes tag.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/builtin-daemon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> > index de76bbc50bfb..18f7f417ba11 100644
> > --- a/tools/perf/builtin-daemon.c
> > +++ b/tools/perf/builtin-daemon.c
> > @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
> > }
> >
> > memset(&cmd, 0, sizeof(cmd));
> > - cmd.signal.cmd = CMD_SIGNAL,
> > + cmd.signal.cmd = CMD_SIGNAL;
> > cmd.signal.sig = SIGUSR2;
> > strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
> >
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-26 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16 7:43 [PATCH] perf daemon: Convert comma to semicolon Chen Ni
2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:14 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).