[PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[weilin.wang]

From: Weilin Wang <weilin.wang@intel.com>

Add a check to return the metric validation test early when perf list metric
does not output any metric. This would happen when NO_JEVENTS=1 is set or in a
system that there is no metric supported.


Signed-off-by: Weilin Wang <weilin.wang@intel.com>
---
 tools/perf/tests/shell/lib/perf_metric_validation.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/shell/lib/perf_metric_validation.py b/tools/perf/tests/shell/lib/perf_metric_validation.py
index a2d235252183..0b94216c9c46 100644
--- a/tools/perf/tests/shell/lib/perf_metric_validation.py
+++ b/tools/perf/tests/shell/lib/perf_metric_validation.py
@@ -95,7 +95,7 @@ class Validator:
                       indent=4)

     def get_results(self, idx: int = 0):
-        return self.results[idx]
+        return self.results.get(idx)

     def get_bounds(self, lb, ub, error, alias={}, ridx: int = 0) -> list:
         """
@@ -173,7 +173,10 @@ class Validator:
         pcnt = 0
         tcnt = 0
         rerun = list()
-        for name, val in self.get_results().items():
+        results = self.get_results()
+        if not results:
+            return
+        for name, val in results.items():
             if val < 0:
                 negmetric[name] = val
                 rerun.append(name)
@@ -532,6 +535,9 @@ class Validator:
         '''
         if not self.collectlist:
             self.parse_perf_metrics()
+        if not self.metrics:
+            print("No metric found for testing")
+            return 0
         self.create_rules()
         for i in range(0, len(self.workloads)):
             self.wlidx = i
--
2.42.0

Re: [PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[Ian Rogers]

On Wed, May 22, 2024 at 1:43 PM <weilin.wang@intel.com> wrote:
>
> From: Weilin Wang <weilin.wang@intel.com>
>
> Add a check to return the metric validation test early when perf list metric
> does not output any metric. This would happen when NO_JEVENTS=1 is set or in a
> system that there is no metric supported.
>
>
> Signed-off-by: Weilin Wang <weilin.wang@intel.com>

Tested-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/perf_metric_validation.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/lib/perf_metric_validation.py b/tools/perf/tests/shell/lib/perf_metric_validation.py
> index a2d235252183..0b94216c9c46 100644
> --- a/tools/perf/tests/shell/lib/perf_metric_validation.py
> +++ b/tools/perf/tests/shell/lib/perf_metric_validation.py
> @@ -95,7 +95,7 @@ class Validator:
>                        indent=4)
>
>      def get_results(self, idx: int = 0):
> -        return self.results[idx]
> +        return self.results.get(idx)
>
>      def get_bounds(self, lb, ub, error, alias={}, ridx: int = 0) -> list:
>          """
> @@ -173,7 +173,10 @@ class Validator:
>          pcnt = 0
>          tcnt = 0
>          rerun = list()
> -        for name, val in self.get_results().items():
> +        results = self.get_results()
> +        if not results:
> +            return
> +        for name, val in results.items():
>              if val < 0:
>                  negmetric[name] = val
>                  rerun.append(name)
> @@ -532,6 +535,9 @@ class Validator:
>          '''
>          if not self.collectlist:
>              self.parse_perf_metrics()
> +        if not self.metrics:
> +            print("No metric found for testing")
> +            return 0
>          self.create_rules()
>          for i in range(0, len(self.workloads)):
>              self.wlidx = i
> --
> 2.42.0
>

Re: [PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[Ian Rogers]

On Fri, May 24, 2024 at 6:26 PM Ian Rogers <irogers@google.com> wrote:
>
> On Wed, May 22, 2024 at 1:43 PM <weilin.wang@intel.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@intel.com>
> >
> > Add a check to return the metric validation test early when perf list metric
> > does not output any metric. This would happen when NO_JEVENTS=1 is set or in a
> > system that there is no metric supported.
> >
> >
> > Signed-off-by: Weilin Wang <weilin.wang@intel.com>
>
> Tested-by: Ian Rogers <irogers@google.com>

Ping.

Thanks,
Ian

Re: [PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[Ian Rogers]

On Mon, Jul 15, 2024 at 3:25 PM Ian Rogers <irogers@google.com> wrote:
>
> On Fri, May 24, 2024 at 6:26 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Wed, May 22, 2024 at 1:43 PM <weilin.wang@intel.com> wrote:
> > >
> > > From: Weilin Wang <weilin.wang@intel.com>
> > >
> > > Add a check to return the metric validation test early when perf list metric
> > > does not output any metric. This would happen when NO_JEVENTS=1 is set or in a
> > > system that there is no metric supported.
> > >
> > >
> > > Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> >
> > Tested-by: Ian Rogers <irogers@google.com>
>
> Ping.

Ping.

Thanks,
Ian

Re: [PATCH v1 1/1] perf test: make metric validation test return early when there is no metric supported on the test system

[Arnaldo Carvalho de Melo]

On Tue, Jul 30, 2024 at 11:44:32AM -0700, Ian Rogers wrote:
> On Mon, Jul 15, 2024 at 3:25 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Fri, May 24, 2024 at 6:26 PM Ian Rogers <irogers@google.com> wrote:
> > >
> > > On Wed, May 22, 2024 at 1:43 PM <weilin.wang@intel.com> wrote:
> > > >
> > > > From: Weilin Wang <weilin.wang@intel.com>
> > > >
> > > > Add a check to return the metric validation test early when perf list metric
> > > > does not output any metric. This would happen when NO_JEVENTS=1 is set or in a
> > > > system that there is no metric supported.
> > > >
> > > >
> > > > Signed-off-by: Weilin Wang <weilin.wang@intel.com>
> > >
> > > Tested-by: Ian Rogers <irogers@google.com>
> >
> > Ping.
> 
> Ping.

Thanks, applied to tmp.perf-tools-next,

- Arnaldo