From: Namhyung Kim <namhyung@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v7 3/4] perf script: Fix perf script -F +metric
Date: Mon, 5 Aug 2024 11:58:37 -0700 [thread overview]
Message-ID: <ZrEg3eWdGCkZQyrg@google.com> (raw)
In-Reply-To: <Zq1IbXj7oxBd7S82@tassilo>
On Fri, Aug 02, 2024 at 01:58:21PM -0700, Andi Kleen wrote:
> > > Not with leader sampling because the group is contiguous and output
> > > after its end, with all the previous values forgotten then.
> > > The other cases don't really work anyways as multiple people pointed
> > > out.
> >
> > Right, but we cannot prevent people to do that.. Maybe we can disable
> > metric with a warning if leader sampling is not used? Or at least add
> > a comment in the code that it's only intended for the use case.
>
> Yes I did that in the version I posted yesterday. It prints a one
> time warning and disables metric output.
Oh ok, I'll take a look at the new version.
Thanks,
Namhyung
next prev parent reply other threads:[~2024-08-05 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 19:01 [PATCH v7 1/4] Create source symlink in perf object dir Andi Kleen
2024-07-24 19:01 ` [PATCH v7 2/4] perf test: Support external tests for separate objdir Andi Kleen
2024-07-26 0:07 ` Namhyung Kim
2024-07-24 19:01 ` [PATCH v7 3/4] perf script: Fix perf script -F +metric Andi Kleen
2024-07-26 0:31 ` Namhyung Kim
2024-07-26 3:13 ` Ian Rogers
2024-07-31 19:32 ` Andi Kleen
2024-08-02 18:26 ` Namhyung Kim
2024-08-02 20:58 ` Andi Kleen
2024-08-05 18:58 ` Namhyung Kim [this message]
2024-07-24 19:01 ` [PATCH v7 4/4] Add a test case for " Andi Kleen
2024-07-26 0:32 ` Namhyung Kim
2024-07-24 20:29 ` [PATCH v7 1/4] Create source symlink in perf object dir Ian Rogers
2024-07-24 21:48 ` Andi Kleen
2024-07-24 22:31 ` Ian Rogers
2024-07-25 7:28 ` Andi Kleen
2024-07-25 9:18 ` Ian Rogers
2024-07-25 22:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrEg3eWdGCkZQyrg@google.com \
--to=namhyung@kernel.org \
--cc=ak@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).