From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Howard Chu <howardchu95@gmail.com>
Cc: adrian.hunter@intel.com, irogers@google.com, jolsa@kernel.org,
kan.liang@linux.intel.com, namhyung@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] perf trace: Collect augmented data using BPF
Date: Fri, 9 Aug 2024 10:21:36 -0300 [thread overview]
Message-ID: <ZrYX4CFLNcI7xfLs@x1> (raw)
In-Reply-To: <20240731194939.4760-3-howardchu95@gmail.com>
On Thu, Aug 01, 2024 at 03:49:38AM +0800, Howard Chu wrote:
> Add task filtering in BPF to avoid collecting useless data.
The above feature should have been on a separate patch, if it is needed
at all, see below.
> SEC("tp/raw_syscalls/sys_enter")
> int sys_enter(struct syscall_enter_args *args)
> {
> @@ -389,6 +501,9 @@ int sys_enter(struct syscall_enter_args *args)
> if (pid_filter__has(&pids_filtered, getpid()))
> return 0;
>
> + if (filter_pid && not_in_filter(getpid()))
> + return 0;
> +
Why do we have two wais of filtering pids? pids_filtered and that
volatile, etc?
- Arnaldo
next prev parent reply other threads:[~2024-08-09 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 19:49 [PATCH v1 0/3] perf trace: Augment struct pointer arguments Howard Chu
2024-07-31 19:49 ` [PATCH v1 1/3] perf trace: Set up beauty_map, load it to BPF Howard Chu
2024-07-31 19:49 ` [PATCH v1 2/3] perf trace: Collect augmented data using BPF Howard Chu
2024-08-09 13:21 ` Arnaldo Carvalho de Melo [this message]
2024-07-31 19:49 ` [PATCH v1 3/3] perf trace: Fix perf trace -p <PID> Howard Chu
2024-08-01 15:31 ` [PATCH v1 0/3] perf trace: Augment struct pointer arguments Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrYX4CFLNcI7xfLs@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).