From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Colin Ian King <colin.i.king@gmail.com>,
Casey Chen <cachen@purestorage.com>,
Tom Zanussi <tzanussi@gmail.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf inject: Inject build ids for entire call chain
Date: Mon, 12 Aug 2024 17:54:25 -0300 [thread overview]
Message-ID: <Zrp2gdY87ZFlmMaW@x1> (raw)
In-Reply-To: <CAP-5=fUy6sx5ZMs6L1we2tpaq1iyUz4GW_ps7c7xE1zqjVzvgg@mail.gmail.com>
On Mon, Aug 12, 2024 at 01:43:59PM -0700, Ian Rogers wrote:
> On Fri, Aug 2, 2024 at 11:23 AM Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > Hi Ian,
> >
> > On Wed, Jul 31, 2024 at 08:12:49PM -0700, Ian Rogers wrote:
> > > The DSO build id is injected when the dso is first encountered but the
> > > checking for first encountered only looks at the sample->ip not the
> > > entire callchain. Use the callchain logic to ensure all build ids are
> > > inserted.
> > >
> > > Add a for_each callback style API to callchain with
> > > sample__for_each_callchain_node. Possibly in the future such an API
> > > can avoid the overhead of constructing the call chain list.
> > >
> > > Fixes: 454c407ec17a ("perf: add perf-inject builtin")
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> >
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Ping.
This one isn't applying, maybe a clash with the previous patch or the
constify series?
Please take a look at wat is now in tmp.perf-tools-next
- Arnaldo
prev parent reply other threads:[~2024-08-12 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 3:12 [PATCH v1] perf inject: Inject build ids for entire call chain Ian Rogers
2024-08-02 18:23 ` Namhyung Kim
2024-08-12 20:43 ` Ian Rogers
2024-08-12 20:54 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrp2gdY87ZFlmMaW@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=cachen@purestorage.com \
--cc=colin.i.king@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).