From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Matt Fleming <matt@readmodwrite.com>
Subject: Re: [PATCH 1/4] perf report: Fix segfault when 'sym' sort key is not used
Date: Wed, 28 Aug 2024 18:23:11 -0300 [thread overview]
Message-ID: <Zs-VP5uWCeIdooB_@x1> (raw)
In-Reply-To: <20240826221045.1202305-2-namhyung@kernel.org>
On Mon, Aug 26, 2024 at 03:10:42PM -0700, Namhyung Kim wrote:
> The fields in the hist_entry are filled on-demand which means they only
> have meaningful values when relevant sort keys are used. So if neither
> of 'dso' nor 'sym' sort keys are used, the map/symbols in the hist entry
> can be garbage. So it shouldn't access it unconditionally.
>
> I got a segfault, when I wanted to see cgroup profiles.
Thanks, applied the series to perf-tools-next,
- Arnaldo
next prev parent reply other threads:[~2024-08-28 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 22:10 [PATCH 0/4] perf bpf-filter: Add cgroup filter term (v1) Namhyung Kim
2024-08-26 22:10 ` [PATCH 1/4] perf report: Fix segfault when 'sym' sort key is not used Namhyung Kim
2024-08-28 21:23 ` Arnaldo Carvalho de Melo [this message]
2024-08-26 22:10 ` [PATCH 2/4] perf bpf-filter: Add build dependency to header files Namhyung Kim
2024-08-26 22:10 ` [PATCH 3/4] perf bpf-filter: Support filtering on cgroups Namhyung Kim
2024-08-26 22:10 ` [PATCH 4/4] perf test: Add perf record cgroup filtering test Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs-VP5uWCeIdooB_@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=matt@readmodwrite.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).