linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: James Clark <james.clark@linaro.org>
Cc: irogers@google.com, linux-perf-users@vger.kernel.org,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
	Leo Yan <leo.yan@linux.dev>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Weilin Wang <weilin.wang@intel.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Yang Jihong <yangjihong@bytedance.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	Ze Gao <zegao2021@gmail.com>,
	Jing Zhang <renyu.zj@linux.alibaba.com>,
	Sun Haiyong <sunhaiyong@loongson.cn>,
	Yicong Yang <yangyicong@hisilicon.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/7] Event parsing fixes
Date: Tue, 27 Aug 2024 22:16:31 -0700	[thread overview]
Message-ID: <Zs6yrwmn-rJWWaCr@tassilo> (raw)
In-Reply-To: <20240822132506.1468090-1-james.clark@linaro.org>

> There is one small difference where it now shows "stalled-cycles-..."
> as <not supported> events, when before it just didn't show them at all when
> they weren't supported:
> 
>   $ perf stat -- true
> 
>   Performance counter stats for 'true':
> 
>               0.66 msec task-clock                       #    0.384 CPUs utilized             
>                  0      context-switches                 #    0.000 /sec                      
>                  0      cpu-migrations                   #    0.000 /sec                      
>                 52      page-faults                      #   78.999 K/sec                     
>      <not counted>      cpu_atom/instructions/                                                  (0.00%)
>            978,399      cpu_core/instructions/           #    1.02  insn per cycle            
>      <not counted>      cpu_atom/cycles/                                                        (0.00%)
>            959,722      cpu_core/cycles/                 #    1.458 GHz                       
>    <not supported>      cpu_atom/stalled-cycles-frontend/                                      
>    <not supported>      cpu_core/stalled-cycles-frontend/                                      
> 
> I don't think that's a big deal though and could probably be fixed up
> later if we really want to.

I would prefer if that was fixed up. That's quite ugly for the default
view on x86/Intel.

-Andi

      parent reply	other threads:[~2024-08-28  5:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22 13:24 [PATCH v4 0/7] Event parsing fixes James Clark
2024-08-22 13:24 ` [PATCH v4 1/7] perf evsel: Add alternate_hw_config and use in evsel__match James Clark
2024-08-22 13:24 ` [PATCH v4 2/7] perf stat: Uniquify event name improvements James Clark
2024-08-22 13:24 ` [PATCH v4 3/7] perf stat: Remove evlist__add_default_attrs use strings James Clark
2024-08-22 13:24 ` [PATCH v4 4/7] perf evsel x86: Make evsel__has_perf_metrics work for legacy events James Clark
2024-08-22 13:24 ` [PATCH v4 5/7] perf evsel: Remove pmu_name James Clark
2024-08-22 13:24 ` [PATCH v4 6/7] perf test: Make stat test work on DT devices James Clark
2024-08-22 13:24 ` [PATCH v4 7/7] perf test: Add a test for default perf stat command James Clark
2024-08-22 14:32 ` [PATCH v4 0/7] Event parsing fixes Liang, Kan
2024-08-22 15:10   ` Ian Rogers
2024-08-22 15:18     ` Liang, Kan
2024-08-27  9:13       ` James Clark
2024-08-28  5:16 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zs6yrwmn-rJWWaCr@tassilo \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=asmadeus@codewreck.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=colin.i.king@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=sunhaiyong@loongson.cn \
    --cc=weilin.wang@intel.com \
    --cc=will@kernel.org \
    --cc=yangjihong@bytedance.com \
    --cc=yangyicong@hisilicon.com \
    --cc=zegao2021@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).