From: Andi Kleen <ak@linux.intel.com>
To: James Clark <james.clark@linaro.org>
Cc: irogers@google.com, linux-perf-users@vger.kernel.org,
kan.liang@linux.intel.com, John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Yang Jihong <yangjihong@bytedance.com>,
Colin Ian King <colin.i.king@gmail.com>,
Ze Gao <zegao2021@gmail.com>, Yunseong Kim <yskelg@gmail.com>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/7] Event parsing fixes
Date: Wed, 28 Aug 2024 10:02:16 -0700 [thread overview]
Message-ID: <Zs9YGP4d0_QanpoA@tassilo> (raw)
In-Reply-To: <20240828140736.156703-1-james.clark@linaro.org>
On Wed, Aug 28, 2024 at 03:07:14PM +0100, James Clark wrote:
> I rebased this one and made some other fixes so that I could test it,
> so I thought I'd repost it here in case it's helpful. I also added a
> new test.
>
> But for the testing it all looks ok.
>
> There is one small difference where it now hides _all_ <not supported>
> events, when previously it would only hide some selected subset of
> events like "stalled-cycles-frontend". I think this is now more
> consistent across platforms because, for example, Apple M only has
> cycles and instructions, and the rest of the default events would
> always show as <not supported> there.
I'm not a big fan of hiding all of <unsupported>, when they are explicitly
specified on the command line they should be absolutely shown.
I do have tools that specify events on the command line and expect
the same order/events in the output. This might well cause breakage.
-Andi
next prev parent reply other threads:[~2024-08-28 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 14:07 [PATCH v5 0/7] Event parsing fixes James Clark
2024-08-28 14:07 ` [PATCH v5 1/7] perf evsel: Add alternate_hw_config and use in evsel__match James Clark
2024-08-28 14:07 ` [PATCH v5 2/7] perf stat: Uniquify event name improvements James Clark
2024-08-28 14:07 ` [PATCH v5 3/7] perf stat: Remove evlist__add_default_attrs use strings James Clark
2024-08-28 14:07 ` [PATCH v5 4/7] perf evsel x86: Make evsel__has_perf_metrics work for legacy events James Clark
2024-08-28 14:07 ` [PATCH v5 5/7] perf evsel: Remove pmu_name James Clark
2024-08-28 14:07 ` [PATCH v5 6/7] perf test: Make stat test work on DT devices James Clark
2024-08-28 14:07 ` [PATCH v5 7/7] perf test: Add a test for default perf stat command James Clark
2024-08-30 6:32 ` Namhyung Kim
2024-08-30 8:29 ` James Clark
2024-08-30 8:45 ` James Clark
2024-09-02 17:43 ` Namhyung Kim
2024-08-28 17:02 ` Andi Kleen [this message]
2024-08-28 17:14 ` [PATCH v5 0/7] Event parsing fixes Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs9YGP4d0_QanpoA@tassilo \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=colin.i.king@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=sunhaiyong@loongson.cn \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangjihong@bytedance.com \
--cc=yangyicong@hisilicon.com \
--cc=yskelg@gmail.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).