From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] perf annotate-data: Show offset and size in hex
Date: Wed, 21 Aug 2024 11:45:27 -0300 [thread overview]
Message-ID: <ZsX9hyFnVNCZg40u@x1> (raw)
In-Reply-To: <CAM9d7cjLvS5BUO_AEkfR3LsT8SNB8MCt-DTHCiRDrZyQxhySoQ@mail.gmail.com>
On Mon, Aug 19, 2024 at 07:21:34PM -0700, Namhyung Kim wrote:
> On Mon, Aug 19, 2024 at 5:12 PM Arnaldo Carvalho de Melo
> <arnaldo.melo@gmail.com> wrote:
> >
> >
> >
> > On Mon, Aug 19, 2024, 8:36 PM Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >> It'd be better to have them in hex to check cacheline alignment.
> >>
> >>
> > Why is it better? To compare with the usual output of some other tool?
> >
> > Spelling out reasons helps reviewers/users.
>
> Cache line sizes are power of 2 so it'd be natural to use hex and
> check whether an offset is in the same boundary. Also perf annotate
> shows instruction offsets in hex.
>
> >
> > Maybe this should be selectable?
>
> I can add an option and/or a config if you want.
It would be interesting to have, but I'm merging the patches to make
progress...
- Arnaldo
prev parent reply other threads:[~2024-08-21 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 23:36 [PATCH 1/2] perf annotate-data: Show offset and size in hex Namhyung Kim
2024-08-19 23:36 ` [PATCH 2/2] perf annotate-data: Add 'typecln' sort key Namhyung Kim
[not found] ` <CA+JHD93fa33YL_AHL9RfxUOoBm+hw8zHbk13BU4qD8B3p4KHug@mail.gmail.com>
2024-08-20 2:21 ` [PATCH 1/2] perf annotate-data: Show offset and size in hex Namhyung Kim
2024-08-21 14:45 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsX9hyFnVNCZg40u@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).