linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: kan.liang@linux.intel.com, irogers@google.com,
	peterz@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf hist: Don't set hpp_fmt_value for members in --no-group
Date: Mon, 26 Aug 2024 11:33:39 -0300	[thread overview]
Message-ID: <ZsySQ9MADfhrABFy@x1> (raw)
In-Reply-To: <CAM9d7ch1tmkmrpcxdW4Txz20Xzt6NFx_-0m6HQzTwXAV7Opg2Q@mail.gmail.com>

On Wed, Aug 21, 2024 at 05:38:45PM -0700, Namhyung Kim wrote:
> Hi Kan,
> 
> On Tue, Aug 20, 2024 at 11:31 AM <kan.liang@linux.intel.com> wrote:
> >
> > From: Kan Liang <kan.liang@linux.intel.com>
> >
> > Perf crashes as below when applying --no-group
> >
> > perf record -e "{cache-misses,branches"} -b sleep 1
> > perf report --stdio --no-group
> > free(): invalid next size (fast)
> > Aborted (core dumped)
> >
> > In the __hpp__fmt(), only 1 hpp_fmt_value is allocated for the current
> > event when --no-group is applied. However, the current implementation
> > tries to assign the hists from all members to the hpp_fmt_value, which
> > exceeds the allocated memory.
> >
> > Fixes: 8f6071a3dce4 ("perf hist: Simplify __hpp_fmt() using hpp_fmt_data")
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied to perf-tools-next,

- Arnaldo

      reply	other threads:[~2024-08-26 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 18:32 [PATCH] perf hist: Don't set hpp_fmt_value for members in --no-group kan.liang
2024-08-22  0:38 ` Namhyung Kim
2024-08-26 14:33   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsySQ9MADfhrABFy@x1 \
    --to=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).