From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8A41A2621 for ; Mon, 2 Sep 2024 14:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725288112; cv=none; b=CqOMvzICUkT9dtqcGWPcWYDkTOOd6jrDVqmSJp0TET/AGoHsq7u7aG9cLxtvn9wpKRLUKMrVuawmNCFb6/o6JkX6eb+zUAjJV2L+evgzIiXaoqcSiXmeudwv1PPZvxVBfDS3X9v/iDlPRIiLDNVSTETNDrExcX3wpjA9cY/EUaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725288112; c=relaxed/simple; bh=U82ddIP+N60SGK6uHNP0lqEI5H79gXfWAdDTlINGm6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nGR8Wg0dp/v0VvHpFbjm7jUnCeBo8uJSg+Zo2ZK/l89WjyoDa04PiF2hEY5IodDzXq2YsSAIBgk/AytgjCBVAHT5MaIxb5dG4ManJNGtanuKKR3FtkQTr4yzCsNegy48d6aGc9iagUtTDQ3YJL3BHdAmrUYeNhobGE69KQ7ccow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a+AOpXJw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a+AOpXJw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8DE7C4CEC7; Mon, 2 Sep 2024 14:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725288112; bh=U82ddIP+N60SGK6uHNP0lqEI5H79gXfWAdDTlINGm6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a+AOpXJwzT0gmaO8xXqWr6d+t9ED9QPCzs00YQpDQ6dCuxTACgwQlJFIEupSSjxcr /lkZnV4cBqtVZMeov3p3TN09OYnV4w7aJE95+a/RAd9B7lqQQzQxDDVOlutcF/TZYa wNkUbKmKo1NlJ4xYquG2XKffv2hCA/kr6HTIbF6qbEWxBF2POmCSo5DkhZzW4NdWAF TvBpwU99/t6S7YYc1hCq6Hq39t3vQ1duzMUok7YPtj8FPEI1dXPr7LbO6LREFBzX5M 6roa1HHDlYbv3sUk3qIymHQNKwm/CA+0kjCctKJdBTfkPIzgd4OAOJa6GiBbMkb/Nz X5SG+hlSJOjHA== Date: Mon, 2 Sep 2024 11:41:48 -0300 From: Arnaldo Carvalho de Melo To: Veronika Molnarova Cc: linux-perf-users@vger.kernel.org, acme@redhat.com, namhyung@kernel.org, mpetlan@redhat.com, irogers@google.com, atrajeev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com Subject: Re: [PATCH v2 00/11] perftool-testsuite 2nd batch Message-ID: References: <20240702110849.31904-1-vmolnaro@redhat.com> <66bed21e-1ea6-4676-b202-dd7c2f2f847c@redhat.com> <6b8245be-7fbf-41e9-8622-f8990ae7a880@redhat.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 02, 2024 at 11:31:36AM -0300, Arnaldo Carvalho de Melo wrote: > On Mon, Sep 02, 2024 at 04:05:04PM +0200, Veronika Molnarova wrote: > > On 8/30/24 17:27, Arnaldo Carvalho de Melo wrote: > > > On Wed, Aug 28, 2024 at 05:39:48PM -0300, Arnaldo Carvalho de Melo wrote: > > >> On Wed, Aug 28, 2024 at 04:10:55PM +0200, Veronika Molnarova wrote: > > > So, is there some other knob to get further output from that FAIL case? > > > Like the command that is failing? I'll try to take a look at the > > > sources, but are you seeing this problem with what is in > > > perf-tools-next/perf-tools-next? > > Couldn't reproduce the issue on multiple systems. There is no further way > > of getting more logs from the test case. The output of the failure is from > > the regex checking when a line wasn't matched to any possible regex. > > Looking at the test case "adding blacklisted function warn_thunk_thunk", > > the failure is caused by command 'perf probe warn_thunk_thunk', which is > > a blacklisted function taken from "/sys/kernel/debug/kprobes/blacklist". root@x1:~# grep thunk_thunk /sys/kernel/debug/kprobes/blacklist 0xffffffff97004af0-0xffffffff97004b20 warn_thunk_thunk root@x1:~# > /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.err:A function DIE doesn't have decl_line. Maybe broken DWARF? > root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.err > A function DIE doesn't have decl_line. Maybe broken DWARF? > A function DIE doesn't have decl_line. Maybe broken DWARF? > Probe point 'warn_thunk_thunk' not found. > Error: Failed to add events. > root@x1:~# > root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted_list.log > root@x1:~# cat /tmp/perftool-testsuite_probe.RJh/perf_probe/logs/adding_blacklisted.log > root@x1:~# > > So is it just a matter of adding this output to the expected outputs? > In test_adding_blacklisted.sh? Did the patch below, now it passes, Ack? root@x1:~# export PERFTEST_KEEP_LOGS=y root@x1:~# perf test 88 88: perftool-testsuite_probe : Ok root@x1:~# Or am I missing the point? :-) - Arnaldo diff --git a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh index b5dc10b2a73810b3..14290d08a4a96eaf 100755 --- a/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh +++ b/tools/perf/tests/shell/base_probe/test_adding_blacklisted.sh @@ -42,7 +42,8 @@ REGEX_ERROR_MESSAGE="Error: Failed to add events." REGEX_INVALID_ARGUMENT="Failed to write event: Invalid argument" REGEX_SYMBOL_FAIL="Failed to find symbol at $RE_ADDRESS" REGEX_OUT_SECTION="$BLACKFUNC is out of \.\w+, skip it" -../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" < $LOGS_DIR/adding_blacklisted.err +REGEX_MISSING_DECL_LINE="A function DIE doesn't have decl_line. Maybe broken DWARF?" +../common/check_all_lines_matched.pl "$REGEX_SKIP_MESSAGE" "$REGEX_NOT_FOUND_MESSAGE" "$REGEX_ERROR_MESSAGE" "$REGEX_SCOPE_FAIL" "$REGEX_INVALID_ARGUMENT" "$REGEX_SYMBOL_FAIL" "$REGEX_OUT_SECTION" "$REGEX_MISSING_DECL_LINE" < $LOGS_DIR/adding_blacklisted.err CHECK_EXIT_CODE=$? print_results $PERF_EXIT_CODE $CHECK_EXIT_CODE "adding blacklisted function $BLACKFUNC"