linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org, Song Liu <song@kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCHSET 0/5] perf tools: Constify BPF control data properly (v1)
Date: Tue, 3 Sep 2024 12:18:36 -0300	[thread overview]
Message-ID: <ZtcozBEf_RItlB9Y@x1> (raw)
In-Reply-To: <20240902200515.2103769-1-namhyung@kernel.org>

On Mon, Sep 02, 2024 at 01:05:10PM -0700, Namhyung Kim wrote:
> Hello,
> 
> I've realized that some control data (usually for filter actions)
> should be defined as 'const volatile' so that it can passed to the BPF
> core and to be optimized properly (like with dead code elimination).
> 
> Convert the existing codes with the similar patterns.

Thanks, tested all the features using BPF, applied to perf-tools-next,

- Arnaldo
 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (5):
>   perf stat: Constify control data for BPF
>   perf ftrace latency: Constify control data for BPF
>   perf kwork: Constify control data for BPF
>   perf lock contention: Constify control data for BPF
>   perf record offcpu: Constify control data for BPF
> 
>  tools/perf/util/bpf_counter_cgroup.c          |  6 +--
>  tools/perf/util/bpf_ftrace.c                  |  8 ++--
>  tools/perf/util/bpf_kwork.c                   |  9 ++--
>  tools/perf/util/bpf_kwork_top.c               |  7 +--
>  tools/perf/util/bpf_lock_contention.c         | 45 ++++++++++---------
>  tools/perf/util/bpf_off_cpu.c                 | 16 +++----
>  tools/perf/util/bpf_skel/bperf_cgroup.bpf.c   |  2 +-
>  tools/perf/util/bpf_skel/func_latency.bpf.c   |  7 +--
>  tools/perf/util/bpf_skel/kwork_top.bpf.c      |  2 +-
>  tools/perf/util/bpf_skel/kwork_trace.bpf.c    |  5 ++-
>  .../perf/util/bpf_skel/lock_contention.bpf.c  | 27 +++++------
>  tools/perf/util/bpf_skel/off_cpu.bpf.c        |  9 ++--
>  12 files changed, 76 insertions(+), 67 deletions(-)
> 
> -- 
> 2.46.0.469.g59c65b2a67-goog

      parent reply	other threads:[~2024-09-03 15:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02 20:05 [PATCHSET 0/5] perf tools: Constify BPF control data properly (v1) Namhyung Kim
2024-09-02 20:05 ` [PATCH 1/5] perf stat: Constify control data for BPF Namhyung Kim
2024-09-02 20:05 ` [PATCH 2/5] perf ftrace latency: " Namhyung Kim
2024-09-02 20:05 ` [PATCH 3/5] perf kwork: " Namhyung Kim
2024-09-02 20:05 ` [PATCH 4/5] perf lock contention: " Namhyung Kim
2024-09-02 20:05 ` [PATCH 5/5] perf record offcpu: " Namhyung Kim
2024-09-03 15:18 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtcozBEf_RItlB9Y@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).