public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Aditya Gupta <adityag@linux.ibm.com>
Cc: jolsa@kernel.org, irogers@google.com, namhyung@kernel.org,
	linux-perf-users@vger.kernel.org, maddy@linux.ibm.com,
	atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com,
	disgoel@linux.vnet.ibm.com
Subject: Re: [PATCH v15 7/7] perf: Add more features to supported_features list
Date: Wed, 4 Sep 2024 17:02:31 -0300	[thread overview]
Message-ID: <Zti81yV0jRIB7oQ6@x1> (raw)
In-Reply-To: <20240904190132.415212-8-adityag@linux.ibm.com>

On Thu, Sep 05, 2024 at 12:31:32AM +0530, Aditya Gupta wrote:
> As suggested in [1], add more feature names and corresponding names,
> based on the information in Makefile.config
> 
> The entries were added after seeing the corresponding -D option which is
> added to CFLAGS, based on the presence of a feature in Makefile.config,
> such as:
> 
>     ifeq ($(feature-file-handle), 1)
>       CFLAGS += -DHAVE_FILE_HANDLE
>     endif
> 
> For above feature 'file-handle', corresponding entry has been added to
> supported_features as below:
> 
>     FEATURE_STATUS("file-handle", HAVE_FILE_HANDLE)
> 
> [1]: https://lore.kernel.org/linux-perf-users/Zn7EvDbsnlbLXj4g@x1/

I'll remove this now because there were some that sounds really strange,
like:

acme@x1:~/git/perf-tools-next$ sudo su -
[sudo] password for acme: 
root@x1:~# perf -vv
perf version 6.11.rc3.g15dc9f274b8e
                 glibc: [ OFF ]  # LIBC_SUPPORT
libslang-include-subdir: [ OFF ]  # HAVE_SLANG_INCLUDE_SUBDIR


The first one is the strange one, how come, no LIBC_SUPPORT? glibc?

The second looks irrelevant, I'll see.

- Arnaldo

  reply	other threads:[~2024-09-04 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 19:01 [PATCH v15 0/7] Introduce perf check subcommand Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 1/7] libsubcmd: Don't free the usage string Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 2/7] perf check: Introduce 'check' subcommand Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 3/7] perf version: Update --build-options to use 'supported_features' array Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 4/7] tools/perf/tests: Update test_task_analyzer.sh to use perf check feature Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 5/7] tools/perf/tests: Update probe_vfs_getname.sh script " Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 6/7] perf: Fix inconsistencies in feature names Aditya Gupta
2024-09-04 19:01 ` [PATCH v15 7/7] perf: Add more features to supported_features list Aditya Gupta
2024-09-04 20:02   ` Arnaldo Carvalho de Melo [this message]
2024-09-05 14:33     ` Aditya Gupta
2024-09-05 14:58       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zti81yV0jRIB7oQ6@x1 \
    --to=acme@kernel.org \
    --cc=adityag@linux.ibm.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=disgoel@linux.vnet.ibm.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox