linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: namhyung@kernel.org, irogers@google.com, jolsa@kernel.org,
	adrian.hunter@intel.com, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] perf mem: Fix missed p-core mem events on ADL and RPL
Date: Fri, 6 Sep 2024 17:06:21 -0300	[thread overview]
Message-ID: <ZttgvduaKsVn1r4p@x1> (raw)
In-Reply-To: <8644996b-33d6-4eee-890c-f23a3c830b77@linux.intel.com>

On Fri, Sep 06, 2024 at 12:08:52PM -0400, Liang, Kan wrote:
> On 2024-09-06 10:17 a.m., Arnaldo Carvalho de Melo wrote:
> > On Thu, Sep 05, 2024 at 03:47:03PM -0400, Liang, Kan wrote:
> >> On 2024-09-05 3:33 p.m., Arnaldo Carvalho de Melo wrote:
> >>> But can we reconstruct the events relationship (group, :S, etc) from
> >>> what we have in the perf.data header?

> >> Do you mean show the group relation in the perf evlist?

> >> $perf mem record sleep 1
> >> [ perf record: Woken up 1 times to write data ]
> >> [ perf record: Captured and wrote 0.027 MB perf.data (10 samples) ]

> >> $perf evlist -g
> >> cpu_atom/mem-loads,ldlat=30/P
> >> cpu_atom/mem-stores/P
> >> {cpu_core/mem-loads-aux/,cpu_core/mem-loads,ldlat=30/}
> >> cpu_core/mem-stores/P
> >> dummy:u

> >> The -g option already did it, although the group modifier looks lost.

> > Right, I can reproduce that, but I wonder if we shouldn't make this '-g'
> > option the default?

> I think the evlist means a list of events. Only outputting the events
> makes sense to me.
> With -g, the extra relationship information is provided.

At first 'perf evlist' showing just the events present in the perf.data
file seems enough, and maybe it should continue like that.

It is just that this relationship is so critical that not showing it by
default looks suboptimal :-\

Perhaps we should add some warning at the end mentioning the special
relationships present and suggest using '-g' to see it?

- Arnaldo

  reply	other threads:[~2024-09-06 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 17:07 [PATCH 1/3] perf mem: Check mem_events for all eligible PMUs kan.liang
2024-09-05 17:07 ` [PATCH 2/3] perf mem: Fix missed p-core mem events on ADL and RPL kan.liang
2024-09-05 19:33   ` Arnaldo Carvalho de Melo
2024-09-05 19:47     ` Liang, Kan
2024-09-06 14:17       ` Arnaldo Carvalho de Melo
2024-09-06 16:08         ` Liang, Kan
2024-09-06 20:06           ` Arnaldo Carvalho de Melo [this message]
2024-09-08 20:30             ` Liang, Kan
2024-09-11 15:56               ` Arnaldo Carvalho de Melo
2024-09-05 17:07 ` [PATCH 3/3] perf mem: Fix the wrong reference in parse_record_events kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZttgvduaKsVn1r4p@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).