From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Yang Li <yang.lee@linux.alibaba.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c
Date: Wed, 11 Sep 2024 09:35:55 -0300 [thread overview]
Message-ID: <ZuGOq_8StU-ChcE8@x1> (raw)
In-Reply-To: <42fd10c1-21fe-48bb-b7ee-c5b42eda7afc@linaro.org>
On Wed, Sep 11, 2024 at 10:50:33AM +0100, James Clark wrote:
>
>
> On 10/09/2024 01:55, Yang Li wrote:
> > The header files parse-events.h is included twice in parse-events.c,
> > so one inclusion of each can be removed.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > tools/perf/tests/parse-events.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> > index 639e65a9bf61..e228511c85a5 100644
> > --- a/tools/perf/tests/parse-events.c
> > +++ b/tools/perf/tests/parse-events.c
> > @@ -5,7 +5,6 @@
> > #include <api/fs/fs.h>
> > #include "tests.h"
> > #include "debug.h"
> > -#include "parse-events.h"
> > #include "pmu.h"
> > #include "pmus.h"
> > #include <dirent.h>
>
> Reviewed-by: James Clark <james.clark@linaro.org>
Thanks, applied to perf-tools-next,
- Arnaldo
prev parent reply other threads:[~2024-09-11 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 0:55 [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c Yang Li
2024-09-11 9:50 ` James Clark
2024-09-11 12:35 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuGOq_8StU-ChcE8@x1 \
--to=acme@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=james.clark@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).