* [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c
@ 2024-09-10 0:55 Yang Li
2024-09-11 9:50 ` James Clark
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2024-09-10 0:55 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung
Cc: linux-perf-users, linux-kernel, Yang Li, Abaci Robot
The header files parse-events.h is included twice in parse-events.c,
so one inclusion of each can be removed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
tools/perf/tests/parse-events.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 639e65a9bf61..e228511c85a5 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -5,7 +5,6 @@
#include <api/fs/fs.h>
#include "tests.h"
#include "debug.h"
-#include "parse-events.h"
#include "pmu.h"
#include "pmus.h"
#include <dirent.h>
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c
2024-09-10 0:55 [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c Yang Li
@ 2024-09-11 9:50 ` James Clark
2024-09-11 12:35 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: James Clark @ 2024-09-11 9:50 UTC (permalink / raw)
To: Yang Li
Cc: linux-perf-users, linux-kernel, Abaci Robot, peterz, mingo, acme,
namhyung
On 10/09/2024 01:55, Yang Li wrote:
> The header files parse-events.h is included twice in parse-events.c,
> so one inclusion of each can be removed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> tools/perf/tests/parse-events.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index 639e65a9bf61..e228511c85a5 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -5,7 +5,6 @@
> #include <api/fs/fs.h>
> #include "tests.h"
> #include "debug.h"
> -#include "parse-events.h"
> #include "pmu.h"
> #include "pmus.h"
> #include <dirent.h>
Reviewed-by: James Clark <james.clark@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c
2024-09-11 9:50 ` James Clark
@ 2024-09-11 12:35 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-09-11 12:35 UTC (permalink / raw)
To: James Clark
Cc: Yang Li, linux-perf-users, linux-kernel, Abaci Robot, peterz,
mingo, namhyung
On Wed, Sep 11, 2024 at 10:50:33AM +0100, James Clark wrote:
>
>
> On 10/09/2024 01:55, Yang Li wrote:
> > The header files parse-events.h is included twice in parse-events.c,
> > so one inclusion of each can be removed.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10822
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > tools/perf/tests/parse-events.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> > index 639e65a9bf61..e228511c85a5 100644
> > --- a/tools/perf/tests/parse-events.c
> > +++ b/tools/perf/tests/parse-events.c
> > @@ -5,7 +5,6 @@
> > #include <api/fs/fs.h>
> > #include "tests.h"
> > #include "debug.h"
> > -#include "parse-events.h"
> > #include "pmu.h"
> > #include "pmus.h"
> > #include <dirent.h>
>
> Reviewed-by: James Clark <james.clark@linaro.org>
Thanks, applied to perf-tools-next,
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-11 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 0:55 [PATCH -next] perf parse-events: Remove duplicated include in parse-events.c Yang Li
2024-09-11 9:50 ` James Clark
2024-09-11 12:35 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).