From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A277A185B7F; Wed, 11 Sep 2024 14:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726064811; cv=none; b=aen1QCCw8BXtSYbmeMvixMBNQOhajGtf99WW2ene7PdnIdJj6qdPzPhfbnSU2u/StGO6tHSSBt3IcSuMGdxuolS1R31e1LH3pOuWB2sp7eZxpr0aM3zhyFOdQ0XFQRlxZA74QXxk4bgl2+gVADcAW6mxYOHjAjDsLBB5uSxWh9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726064811; c=relaxed/simple; bh=GyOydcKwxKTqPcJaT9VvpHocCXPnTdPdYhYuSdMs/WQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HkkU/D0Dh9WFKaCzBXL4Z5W3QiPujub7mKXyF975YqzdByYgL83OqJO5cqYdrD8jaOlV8XWH6BAIw6s4lyFvi9teFJs0/30L6abmK/fpRJT7SCHv4ufmk2nC+hBJS09u8PO7h44p4GfGurhx2v/C8Avvn6IQ9tAcMDnuF1jC/nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fX23i1SB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fX23i1SB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3A1DC4CEC0; Wed, 11 Sep 2024 14:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726064811; bh=GyOydcKwxKTqPcJaT9VvpHocCXPnTdPdYhYuSdMs/WQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fX23i1SB5C/j0YTxs1bA9zAMI/+DGjN1dbz7WQDSLeDvjXMJDHhtqMGj9Kgfto0tn o7Ba89sCX2BVYMVvR6hrvXJiK0JeY8aDOpnIMYlYkz46+Y4jBc/yEJUDEfOmvbmsMN y5huQveC4K9noRQO0DwCLC9VmpT/ZkQv3CjQmUJpUrCQDcmser4X7e1Zv5GHztcTvQ toswBOSKji+Bb8dQi3QRqgdKsJ26ctBU5iTsHiD9tA5WhXFwkJzXHcXzz84nGQHGjv JltP6g/0WLnfpq7jjcmdlcnUCL+HjlR53N1ZsdaaLj26zouu0QXVIhHjopC5YvpKmp l+KpUCk2SrP1w== Date: Wed, 11 Sep 2024 11:26:47 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ravi Bangoria , Weilin Wang , Jing Zhang , Xu Yang , Sandipan Das , Benjamin Gray , Athira Jajeev , Howard Chu , Dominique Martinet , Yang Jihong , Colin Ian King , Veronika Molnarova , "Dr. David Alan Gilbert" , Oliver Upton , Changbin Du , Ze Gao , Andi Kleen , =?iso-8859-1?Q?Cl=E9ment?= Le Goffic , Sun Haiyong , Junhao He , Tiezhu Yang , Yicong Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 01/15] perf list: Avoid potential out of bounds memory read Message-ID: References: <20240907050830.6752-1-irogers@google.com> <20240907050830.6752-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240907050830.6752-2-irogers@google.com> On Fri, Sep 06, 2024 at 10:08:16PM -0700, Ian Rogers wrote: > If a desc string is 0 length then -1 will be out of bounds, add a > check. Cherry picked this one. - Arnaldo > Signed-off-by: Ian Rogers > --- > tools/perf/builtin-list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > index 82cb4b1010aa..65b8cba324be 100644 > --- a/tools/perf/builtin-list.c > +++ b/tools/perf/builtin-list.c > @@ -173,7 +173,7 @@ static void default_print_event(void *ps, const char *pmu_name, const char *topi > if (pmu_name && strcmp(pmu_name, "default_core")) { > desc_len = strlen(desc); > desc_len = asprintf(&desc_with_unit, > - desc[desc_len - 1] != '.' > + desc_len > 0 && desc[desc_len - 1] != '.' > ? "%s. Unit: %s" : "%s Unit: %s", > desc, pmu_name); > } > -- > 2.46.0.469.g59c65b2a67-goog